Turbopack react-refresh: perform full reload on runtime error #62359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, runtime errors would not be recovered from. Like the webpack implementation, this addresses the issue by performing a full page reload when recovering from a runtime error. Test Plan: `test/development/acceptance-app/error-recovery.test.ts -- Error recovery app default stuck error`
ijjk
added
area: tests
created-by: Turbopack team
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| buildDuration | 14.4s | 14.4s | N/A |
| buildDurationCached | 7.5s | 6.7s | N/A |
| nodeModulesSize | 196 MB | 196 MB | |
| nextStartRea..uration (ms) | 407ms | 408ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| 1068-HASH.js gzip | 30.3 kB | 30.3 kB | N/A |
| 3f784ff6-HASH.js gzip | 53.5 kB | 53.5 kB | N/A |
| 4944-HASH.js gzip | 5.04 kB | 5.03 kB | N/A |
| 8423.HASH.js gzip | 181 B | 181 B | ✓ |
| framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
| main-app-HASH.js gzip | 243 B | 242 B | N/A |
| main-HASH.js gzip | 32.2 kB | 32.1 kB | N/A |
| webpack-HASH.js gzip | 1.7 kB | 1.7 kB | ✓ |
| Overall change | 47.1 kB | 47.1 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 196 B | 196 B | ✓ |
| _error-HASH.js gzip | 184 B | 183 B | N/A |
| amp-HASH.js gzip | 503 B | 504 B | N/A |
| css-HASH.js gzip | 323 B | 324 B | N/A |
| dynamic-HASH.js gzip | 2.5 kB | 2.51 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 259 B | N/A |
| head-HASH.js gzip | 353 B | 351 B | N/A |
| hooks-HASH.js gzip | 370 B | 370 B | ✓ |
| image-HASH.js gzip | 4.21 kB | 4.2 kB | N/A |
| index-HASH.js gzip | 259 B | 259 B | ✓ |
| link-HASH.js gzip | 2.68 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 313 B | 314 B | N/A |
| script-HASH.js gzip | 386 B | 385 B | N/A |
| withRouter-HASH.js gzip | 309 B | 311 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 931 B | 931 B | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 485 B | 484 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| index.html gzip | 528 B | 528 B | ✓ |
| link.html gzip | 539 B | 540 B | N/A |
| withRouter.html gzip | 523 B | 522 B | N/A |
| Overall change | 528 B | 528 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 2.3 kB | 2.3 kB | N/A |
| page.js gzip | 2.99 kB | 2.99 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 625 B | 625 B | ✓ |
| middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
| middleware.js gzip | 466 B | 464 B | N/A |
| edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
| Overall change | 1.61 kB | 1.61 kB | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 167 kB | 167 kB | ✓ |
| app-page-exp..prod.js gzip | 96.2 kB | 96.2 kB | ✓ |
| app-page-tur..prod.js gzip | 97.9 kB | 97.9 kB | ✓ |
| app-page-tur..prod.js gzip | 92.4 kB | 92.4 kB | ✓ |
| app-page.run...dev.js gzip | 136 kB | 136 kB | ✓ |
| app-page.run..prod.js gzip | 90.9 kB | 90.9 kB | ✓ |
| app-route-ex...dev.js gzip | 22.1 kB | 22.1 kB | ✓ |
| app-route-ex..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| app-route-tu..prod.js gzip | 14.7 kB | 14.7 kB | ✓ |
| app-route.ru...dev.js gzip | 21.8 kB | 21.8 kB | ✓ |
| app-route.ru..prod.js gzip | 14.7 kB | 14.7 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.49 kB | 9.49 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.76 kB | 9.76 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.48 kB | 9.48 kB | ✓ |
| pages-turbo...prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
| pages.runtim...dev.js gzip | 23 kB | 23 kB | ✓ |
| pages.runtim..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
| server.runti..prod.js gzip | 50.4 kB | 50.4 kB | ✓ |
| Overall change | 930 kB | 930 kB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js wbinnssmith/error-recovery | Change | |
|---|---|---|---|
| 0.pack gzip | 1.49 MB | 1.49 MB | N/A |
| index.pack gzip | 104 kB | 104 kB | |
| Overall change | 104 kB | 104 kB |
wbinnssmith
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
kwonoj
approved these changes
Feb 22, 2024
wbinnssmith
added a commit
that referenced
this pull request
Mar 8, 2024
An iteration of #62359, this uses the module-local flag instead of a shared dedicated module for flagging runtime errors, correctly reloading the page when these occur. Test Plan: See now-passing tests in the manifest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, runtime errors would not be recovered from. Like the webpack implementation, this addresses the issue by performing a full page reload when recovering from a runtime error.
Test Plan:
test/development/acceptance-app/error-recovery.test.ts -- Error recovery app default stuck errorCloses PACK-2569