Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo #63276

Closed
wants to merge 1 commit into from
Closed

fix: typo #63276

wants to merge 1 commit into from

Conversation

testwill
Copy link

No description provided.

@testwill
fix: typo
a41ce75 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@testwill testwill requested review from manovotny and leerob and removed request for a team March 14, 2024 09:55
styfle
styfle reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test will fail since its just the assertion changing but you also need to update the test fixture

@styfle styfle mentioned this pull request Mar 14, 2024
Merged
@styfle
Copy link
Member

styfle commented Mar 14, 2024

There's actually a lot of places this needs to be updated. I created PR #63287

styfle added a commit that referenced this pull request Mar 14, 2024
@styfle
chore(test): fix typo occured => occurred (#63287)
d8a58b5 
Closes #63276

Closes NEXT-2818
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle left review comments

@dcooper-fg dcooper-fg dcooper-fg approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@ztanner ztanner Awaiting requested review from ztanner

@manovotny manovotny Awaiting requested review from manovotny manovotny was automatically assigned from vercel/devex

@leerob leerob Awaiting requested review from leerob leerob was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testwill @styfle @dcooper-fg @ijjk