Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cna): split and refactor #63921

Merged
merged 16 commits into from
Apr 3, 2024
Merged

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Mar 31, 2024

Note: Did not add additional tests or make many changes to the utils, possible refactoring on the following PR.

This PR split the legacy tests into four sections to improve the maintenance and concurrency of CNA tests:

  • prompts: target prompt interactions. Y/n
  • examples: target --example and --example-path flags.
  • templates: target the flag values such as --app, --eslint, etc.
  • package-manager: target package managers: npm, pnpm, yarn, bun

@ijjk
Copy link
Member

ijjk commented Mar 31, 2024

Allow CI Workflow Run

  • approve CI run for commit: 658357d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devjiwonchoi devjiwonchoi changed the title [WIP] test(create-next-app): split, add, and refactor test(cna): split and refactor Apr 1, 2024
@devjiwonchoi devjiwonchoi marked this pull request as ready for review April 1, 2024 14:56
@@ -118,7 +118,6 @@
"abort-controller": "3.0.0",
"alex": "9.1.0",
"amphtml-validator": "1.0.35",
"ansi-escapes": "4.3.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed unused ansi-escapes

@ijjk
Copy link
Member

ijjk commented Apr 1, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Apr 1, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
buildDuration 13.9s 14s N/A
buildDurationCached 7.5s 6.2s N/A
nodeModulesSize 199 MB 199 MB
nextStartRea..uration (ms) 401ms 405ms N/A
Client Bundles (main, webpack)
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 240 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
index.html gzip 529 B 527 B N/A
link.html gzip 541 B 540 B N/A
withRouter.html gzip 524 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
edge-ssr.js gzip 95.3 kB 95.3 kB N/A
page.js gzip 3.04 kB 3.04 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.61 kB 1.61 kB
Next Runtimes
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51 kB 51 kB
Overall change 945 kB 945 kB
build cache Overall increase ⚠️
vercel/next.js canary devjiwonchoi/next.js refactor/test-cna Change
0.pack gzip 1.58 MB 1.58 MB N/A
index.pack gzip 106 kB 106 kB ⚠️ +608 B
Overall change 106 kB 106 kB ⚠️ +608 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 76e77e8

@devjiwonchoi devjiwonchoi requested a review from ijjk April 3, 2024 16:54
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking these up seems good to me, thanks!

@ijjk ijjk merged commit e8349a5 into vercel:canary Apr 3, 2024
72 checks passed
@devjiwonchoi
Copy link
Member Author

Thank you for taking a close look!!

@devjiwonchoi devjiwonchoi deleted the refactor/test-cna branch April 3, 2024 17:18
const examplePath = 'examples/basic-css'
const env = {
...process.env,
COREPACK_ENABLE_STRICT: '0',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also dropped COREPACK_ENABLE_STRICT for package managers

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants