-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix server actions not bypassing prerender cache in all cases when deployed #63978
Merged
ztanner
merged 1 commit into
canary
from
04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed
Apr 2, 2024
Merged
fix server actions not bypassing prerender cache in all cases when deployed #63978
ztanner
merged 1 commit into
canary
from
04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
buildDuration | 13.8s | 13.9s | N/A |
buildDurationCached | 7.5s | 6.1s | N/A |
nodeModulesSize | 199 MB | 199 MB | N/A |
nextStartRea..uration (ms) | 402ms | 397ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
2453-HASH.js gzip | 31.4 kB | 31.4 kB | N/A |
3304.HASH.js gzip | 181 B | 181 B | ✓ |
3f784ff6-HASH.js gzip | 53.7 kB | 53.7 kB | ✓ |
8299-HASH.js gzip | 5.04 kB | 5.04 kB | N/A |
framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
main-app-HASH.js gzip | 242 B | 241 B | N/A |
main-HASH.js gzip | 32.2 kB | 32.2 kB | N/A |
webpack-HASH.js gzip | 1.68 kB | 1.68 kB | N/A |
Overall change | 99 kB | 99 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
_app-HASH.js gzip | 196 B | 197 B | N/A |
_error-HASH.js gzip | 184 B | 184 B | ✓ |
amp-HASH.js gzip | 505 B | 505 B | ✓ |
css-HASH.js gzip | 324 B | 325 B | N/A |
dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
edge-ssr-HASH.js gzip | 258 B | 258 B | ✓ |
head-HASH.js gzip | 352 B | 352 B | ✓ |
hooks-HASH.js gzip | 370 B | 371 B | N/A |
image-HASH.js gzip | 4.21 kB | 4.21 kB | ✓ |
index-HASH.js gzip | 259 B | 259 B | ✓ |
link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
routerDirect..HASH.js gzip | 314 B | 312 B | N/A |
script-HASH.js gzip | 386 B | 386 B | ✓ |
withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 6.57 kB | 6.57 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
_buildManifest.js gzip | 481 B | 484 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
index.html gzip | 528 B | 529 B | N/A |
link.html gzip | 540 B | 541 B | N/A |
withRouter.html gzip | 523 B | 523 B | ✓ |
Overall change | 523 B | 523 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
edge-ssr.js gzip | 95.4 kB | 95.4 kB | N/A |
page.js gzip | 3.06 kB | 3.06 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 624 B | 625 B | N/A |
middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
middleware.js gzip | 25.5 kB | 25.5 kB | N/A |
edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
Overall change | 990 B | 990 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 170 kB | 170 kB | ✓ |
app-page-exp..prod.js gzip | 97 kB | 97 kB | ✓ |
app-page-tur..prod.js gzip | 98.8 kB | 98.8 kB | ✓ |
app-page-tur..prod.js gzip | 93 kB | 93 kB | ✓ |
app-page.run...dev.js gzip | 144 kB | 144 kB | ✓ |
app-page.run..prod.js gzip | 91.5 kB | 91.5 kB | ✓ |
app-route-ex...dev.js gzip | 21.4 kB | 21.4 kB | ✓ |
app-route-ex..prod.js gzip | 15.2 kB | 15.2 kB | ✓ |
app-route-tu..prod.js gzip | 15.2 kB | 15.2 kB | ✓ |
app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
app-route.ru...dev.js gzip | 21.1 kB | 21.1 kB | ✓ |
app-route.ru..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
pages-api-tu..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
pages-api.ru..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
pages-turbo...prod.js gzip | 22.5 kB | 22.5 kB | ✓ |
pages.runtim...dev.js gzip | 23.1 kB | 23.1 kB | ✓ |
pages.runtim..prod.js gzip | 22.4 kB | 22.4 kB | ✓ |
server.runti..prod.js gzip | 51 kB | 51 kB | ✓ |
Overall change | 945 kB | 945 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed | Change | |
---|---|---|---|
0.pack gzip | 1.58 MB | 1.58 MB | |
index.pack gzip | 106 kB | 107 kB | |
Overall change | 1.68 MB | 1.69 MB |
Diff details
Diff for middleware.js
Diff too large to display
ztanner
force-pushed
the
04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed
branch
from
April 2, 2024 15:10
9d99b69
to
285f509
Compare
ztanner
changed the title
fix progressively enhanced server actions not bypassing prerender cache when deployed
fix server actions not bypassing prerender cache in all cases when deployed
Apr 2, 2024
ztanner
force-pushed
the
04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed
branch
from
April 2, 2024 17:15
285f509
to
c324153
Compare
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi,
feedthejim,
a team and
wyattjoh
as code owners
April 2, 2024 18:48
ijjk
approved these changes
Apr 2, 2024
ztanner
deleted the
04-02-fix_progressively_enhanced_server_actions_not_bypassing_prerender_cache_when_deployed
branch
April 2, 2024 21:32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to submit a server action when JS is disabled (ie, no action header in the request, and in the "progressively enhanced" case) for a static resource results in a 405 error when deployed to Vercel. In the absence of an action ID header, the request content-type is used to signal that it shouldn't try and hit the static cache. However with multipart/form-data, this will include the boundary. This updates the matcher to consider a boundary string.
Fixes #58814
Closes NEXT-2980