Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: externalize undici for bundling #64209

Merged
merged 1 commit into from
Apr 9, 2024
Merged

chore: externalize undici for bundling #64209

merged 1 commit into from
Apr 9, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 8, 2024

Currently acornjs has an issue with compiling undici, add undici externalize, once it's resolved we can remove the externalization for it

You may need an additional loader to handle the result of these loaders.
|       // 5. If object is not a default iterator object for interface,
|       //    then throw a TypeError.
>       if (typeof this !== 'object' || this === null || !(#target in this)) {
|         throw new TypeError(
|           `'next' called on an object that does not implement interface ${name} Iterator.`

Import trace for requested module:
../../../../node_modules/.pnpm/undici@6.12.0/node_modules/undici/lib/web/fetch/util.js
../../../../node_modules/.pnpm/undici@6.12.0/node_modules/undici/lib/web/fetch/headers.js
../../../../node_modules/.pnpm/undici@6.12.0/node_modules/undici/index.js
./app/undici/page.js

Closes NEXT-3030

@ijjk
Copy link
Member

ijjk commented Apr 8, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js externalize-udici Change
buildDuration 14.1s 14.2s N/A
buildDurationCached 7.8s 6.5s N/A
nodeModulesSize 199 MB 199 MB N/A
nextStartRea..uration (ms) 405ms 397ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js externalize-udici Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js externalize-udici Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js externalize-udici Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.21 kB 4.21 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.57 kB 6.57 kB
Client Build Manifests
vercel/next.js canary vercel/next.js externalize-udici Change
_buildManifest.js gzip 481 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js externalize-udici Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 522 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js externalize-udici Change
edge-ssr.js gzip 95.4 kB 95.4 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js externalize-udici Change
middleware-b..fest.js gzip 626 B 626 B
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.62 kB 1.62 kB
Next Runtimes
vercel/next.js canary vercel/next.js externalize-udici Change
app-page-exp...dev.js gzip 170 kB 170 kB
app-page-exp..prod.js gzip 97 kB 97 kB
app-page-tur..prod.js gzip 98.8 kB 98.8 kB
app-page-tur..prod.js gzip 93 kB 93 kB
app-page.run...dev.js gzip 144 kB 144 kB
app-page.run..prod.js gzip 91.5 kB 91.5 kB
app-route-ex...dev.js gzip 21.4 kB 21.4 kB
app-route-ex..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 15.1 kB 15.1 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.4 kB 22.4 kB
server.runti..prod.js gzip 51.1 kB 51.1 kB
Overall change 945 kB 945 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js externalize-udici Change
0.pack gzip 1.58 MB 1.58 MB ⚠️ +870 B
index.pack gzip 107 kB 106 kB N/A
Overall change 1.58 MB 1.58 MB ⚠️ +870 B
Diff details
Diff for middleware.js

Diff too large to display

Commit: 8ea2445

@huozhi huozhi marked this pull request as ready for review April 8, 2024 13:04
@huozhi huozhi requested review from timeyoutakeit and molebox and removed request for a team April 8, 2024 13:04
@huozhi huozhi requested a review from a team as a code owner April 8, 2024 21:58
@huozhi huozhi marked this pull request as draft April 8, 2024 21:58
@huozhi huozhi changed the title chore: externalize undici for bundling Update webpack to 5.91.0 Apr 8, 2024
Copy link

socket-security bot commented Apr 8, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/webpack@5.91.0 environment, filesystem, network, unsafe Transitive: eval +52 9.61 MB evilebottnawi

🚮 Removed packages: npm/webpack@5.90.0

View full report↗︎

@huozhi huozhi changed the title Update webpack to 5.91.0 chore: externalize undici for bundling Apr 8, 2024
@huozhi huozhi force-pushed the externalize-udici branch from c587e54 to d851e7f Compare April 8, 2024 22:27
@huozhi huozhi force-pushed the externalize-udici branch from d851e7f to 8ea2445 Compare April 8, 2024 22:30
@huozhi huozhi marked this pull request as ready for review April 8, 2024 22:30
@huozhi huozhi enabled auto-merge (squash) April 8, 2024 22:30
@huozhi huozhi merged commit 5e2ac09 into canary Apr 9, 2024
79 checks passed
@huozhi huozhi deleted the externalize-udici branch April 9, 2024 07:26
@vercel vercel deleted a comment from ijjk Apr 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants