Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DynamicServerError not being thrown in fetch #64511

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Apr 15, 2024

This ensures we properly skip calling a fetch during build-time that has cache: 'no-store' as it should only be called during runtime instead.

Fixes: #64462

Closes NEXT-3114

@ijjk
Copy link
Member Author

ijjk commented Apr 15, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
buildDuration 14.1s 14.1s N/A
buildDurationCached 8.6s 6.4s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +2.35 kB
nextStartRea..uration (ms) 379ms 382ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.1 kB 5.1 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 240 B N/A
main-HASH.js gzip 29.6 kB 29.6 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99 kB 99 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB N/A
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 2.36 kB 2.36 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
index.html gzip 529 B 528 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 525 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
edge-ssr.js gzip 95.6 kB 95.6 kB N/A
page.js gzip 3.05 kB 3.05 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
middleware-b..fest.js gzip 623 B 623 B
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.46 kB 1.46 kB
Next Runtimes
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 97.5 kB 97.5 kB
app-page-tur..prod.js gzip 99.2 kB 99.2 kB
app-page-tur..prod.js gzip 93.5 kB 93.5 kB
app-page.run...dev.js gzip 145 kB 145 kB
app-page.run..prod.js gzip 92 kB 92 kB
app-route-ex...dev.js gzip 21.5 kB 21.5 kB N/A
app-route-ex..prod.js gzip 15.2 kB 15.2 kB N/A
app-route-tu..prod.js gzip 15.2 kB 15.2 kB N/A
app-route-tu..prod.js gzip 14.9 kB 14.9 kB N/A
app-route.ru...dev.js gzip 21.1 kB 21.1 kB N/A
app-route.ru..prod.js gzip 14.9 kB 14.9 kB N/A
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.4 kB 51.4 kB
Overall change 846 kB 846 kB
build cache
vercel/next.js canary ijjk/next.js fix/fetch-bailout Change
0.pack gzip 1.59 MB 1.58 MB N/A
index.pack gzip 107 kB 107 kB N/A
Overall change 0 B 0 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for app-route-ex..ntime.dev.js

Diff too large to display

Diff for app-route-ex..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route-tu..time.prod.js

Diff too large to display

Diff for app-route.runtime.dev.js

Diff too large to display

Diff for app-route.ru..time.prod.js

Diff too large to display

Commit: 49cb2cf

@ijjk ijjk merged commit 4024a89 into vercel:canary Apr 15, 2024
72 of 73 checks passed
ztanner pushed a commit that referenced this pull request Apr 17, 2024
This ensures we properly skip calling a fetch during build-time that has
`cache: 'no-store'` as it should only be called during runtime instead.

Fixes: #64462

Closes NEXT-3114
samcx pushed a commit that referenced this pull request Apr 23, 2024
Bumping `next-sanity` fixes an issue where `@sanity/client` would
swallow the `DynamicServerError` thrown during `next build` in
[v14.2.2](#64511).
The `sanity` bump adds the new `Scheduled Publishing` feature that's
[now in the
core](https://github.com/sanity-io/sanity/releases/tag/v3.39.0).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page with fetch() call and cache: "no-store" does not switch to Dynamic Rendering
2 participants