Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix default.js params example #64748

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Apr 18, 2024

The params example in the docs for default.js have the slot/params in the wrong order, giving the impression that you can deeply nest default slots.

This clarifies that the params received by a slot are based on the dynamic params leading up to the segment containing the slot.

Fixes #64708

Closes NEXT-3160

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Apr 18, 2024
Copy link
Member Author

ztanner commented Apr 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ztanner and the rest of your teammates on Graphite Graphite

@ztanner ztanner marked this pull request as ready for review April 18, 2024 20:56
@ztanner ztanner requested review from a team as code owners April 18, 2024 20:56
@ztanner ztanner requested review from jh3y and timeyoutakeit and removed request for a team April 18, 2024 20:56
@ztanner ztanner merged commit 89b88ee into canary Apr 18, 2024
35 checks passed
@ztanner ztanner deleted the 04-18-docs_fix_default.js_params_example branch April 18, 2024 20:59
@github-actions github-actions bot added the locked label May 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep default.js is completely ignored
2 participants