Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix on a pull request #64911 #64925

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

zsh77
Copy link
Contributor

@zsh77 zsh77 commented Apr 23, 2024

What?

Fixes a bug of removed dependencies by accident, which caused the example not to install dependencies.

How to test?

Running this script should initiate a project that works correctly:

 pnpm create next-app --example with-storybook with-storybook-app

Fixes this pull request #64911

@zsh77 zsh77 requested review from a team as code owners April 23, 2024 16:15
@zsh77 zsh77 requested review from jh3y and timeyoutakeit and removed request for a team April 23, 2024 16:15
@ijjk ijjk added the examples Issue was opened via the examples template. label Apr 23, 2024
@ijjk
Copy link
Member

ijjk commented Apr 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: 09abafe

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Apr 23, 2024

Allow CI Workflow Run

  • approve CI run for commit: 09abafe

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@zsh77
Copy link
Contributor Author

zsh77 commented Apr 23, 2024

@samcx This is a bug fix for a merged PR #64911

@samcx samcx added the CI approved Approve running CI for fork label Apr 23, 2024
@samcx samcx merged commit dd9324f into vercel:canary Apr 23, 2024
34 checks passed
@samcx samcx removed the CI approved Approve running CI for fork label Apr 23, 2024
@github-actions github-actions bot added the locked label May 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants