adopt modern & supported Apollo Client patterns in the with-apollo example #65316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
requested review from
manovotny and
delbaoliveira
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
I don't want to stress anyone, but I really don't feel comfortable with the example that's currently out there. |
samcx
approved these changes
May 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64186 removed the pages router implementation from the
with-apolloexample and replaced it with an app router implementation.Unfortunately, it did so in an unsupported way.
At this point, we can not support any streaming SSR scenario without additional helper packages - in the case of the app router, it is vital to use the
@apollo/experimental-nextjs-app-supportpackage.This PR switches the example to our officially supported patterns.