-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update turbopack & swc_core #65450
Merged
Merged
Update turbopack & swc_core #65450
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0918a91
Update swc_core
kdy1 694a9ab
sync
kdy1 32ad65a
Update swc_core
kdy1 cfb8f62
cargo lockfile
kdy1 08410d3
Update swc crates
kdy1 3ab9017
cargo lockfile
kdy1 ba9ec69
sync
kdy1 f93ab89
sync
kdy1 40b9028
sync
kdy1 1cb8736
Fix compilation
kdy1 d767634
Update test refs
kdy1 bf8e950
Update lightningcss
kdy1 da64272
Update jest snapsho
kdy1 9b7e17d
Update swc_core
kdy1 db8ac80
link next.js
kdy1 578c400
use turbopack tag
ForsakenHarmony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/next-swc/crates/next-custom-transforms/tests/full/example/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/next-swc/crates/next-custom-transforms/tests/loader/auto-cjs/2/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
export default 1; | ||
Object.defineProperty(exports, "__esModule", { | ||
Object.defineProperty(exports, '__esModule', { | ||
value: true | ||
}); |
4 changes: 2 additions & 2 deletions
4
packages/next-swc/crates/next-custom-transforms/tests/loader/auto-cjs/3/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
export default 1; | ||
console.log("__esModule"); | ||
Object.defineProperty({}, "__esModule", { | ||
console.log('__esModule'); | ||
Object.defineProperty({}, '__esModule', { | ||
value: true | ||
}); | ||
Object.defineProperty(); |
2 changes: 1 addition & 1 deletion
2
packages/next-swc/crates/next-custom-transforms/tests/loader/auto-cjs/pack-2074/1/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
export default function(module) { | ||
module.exports = {}; | ||
}; | ||
export var value = "mixed-syntax-esm"; | ||
export var value = 'mixed-syntax-esm'; |
4 changes: 2 additions & 2 deletions
4
packages/next-swc/crates/next-custom-transforms/tests/loader/auto-cjs/pack-2074/2/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
function foo(module) { | ||
module.exports = "this is just normal assignment of scope variable"; | ||
module.exports = 'this is just normal assignment of scope variable'; | ||
} | ||
export var value = "mixed-syntax-esm"; | ||
export var value = 'mixed-syntax-esm'; |
2 changes: 1 addition & 1 deletion
2
packages/next-swc/crates/next-custom-transforms/tests/loader/example/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/next-swc/crates/next-custom-transforms/tests/loader/issue-32553/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
/*#__PURE__*/ React.createElement("div", null, "children"); | ||
"<>hello</>"; | ||
'<>hello</>'; |
2 changes: 1 addition & 1 deletion
2
packages/next-swc/crates/next-custom-transforms/tests/loader/styled-components/1/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this single quote stuff coming from?
Everything else in the output has double quotes (as one would expect)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The windows tests are failing because of this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new swc version used the original style as written in source code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the single quote in the input.
next.js/test/unit/next-swc.test.ts
Line 79 in 578c400