Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove ineffective webpack rules and unused app-page context modules" #65558

Merged
merged 1 commit into from
May 9, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 9, 2024

Reverts #65321

Missed covering api layer, got reported with below error. Revert it for now and will re-land it with more tests

../../node_modules/.pnpm/next@14.3.0-canary.51_@opentelemetry+api@1.7.0_react-dom@18.2.0_react@18.2.0/node_modules/next/dist/client/components/navigation.js
02:23:13
Module not found: shared-runtime module app-router-context cannot be used in api layer
02:23:13
https://nextjs.org/docs/messages/module-not-found

Copy link

linear bot commented May 9, 2024

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels May 9, 2024
@huozhi huozhi requested a review from sokra May 9, 2024 07:43
@huozhi huozhi merged commit 9ee7d7f into canary May 9, 2024
63 of 77 checks passed
@huozhi huozhi deleted the revert-65321-refactor/remove-unused-logic branch May 9, 2024 07:45
huozhi added a commit that referenced this pull request May 13, 2024
huozhi added a commit that referenced this pull request May 13, 2024
…odules (#65694)

Reland #65321 

Added a test to make sure this change will not fail in `pages/api` like
the error mentioned in #65558
panteliselef pushed a commit to panteliselef/next.js that referenced this pull request May 20, 2024
…odules (vercel#65694)

Reland vercel#65321 

Added a test to make sure this change will not fail in `pages/api` like
the error mentioned in vercel#65558
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants