Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-dev-overlay): Open nvim with line number #66358

Merged
merged 3 commits into from
May 30, 2024
Merged

feat(react-dev-overlay): Open nvim with line number #66358

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81ad0e8
feat(react-dev-overlay): Open nvim with line number
notomo May 29, 2024
f6d5661
add nvim to COMMON_EDITORS_LINUX
notomo May 30, 2024
1152efa
Merge branch 'canary' into open-nvim-with-line-number
huozhi May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/next/src/client/components/react-dev-overlay/internal/helpers/launchEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ function isTerminalEditor(editor: string) {
switch (editor) {
case 'vi':
case 'vim':
case 'nvim':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to add to COMMON_EDITORS_LINUX?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for reviewing.
indeed. I'll add commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed f6d5661c5d

case 'emacs':
case 'nano': {
return true
Expand Down Expand Up @@ -160,6 +161,7 @@ function getArgumentsForLineNumber(
return ['-n' + lineNumber, '-c' + colNumber, fileName]
}
case 'vim':
case 'nvim':
case 'mvim':
case 'joe':
case 'gvim': {
Expand Down
Loading