Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update note on Next.js ignoring CRA files #67346

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Docs: Update note on Next.js ignoring CRA files #67346

merged 8 commits into from
Jul 17, 2024

Conversation

delbaoliveira
Copy link
Contributor

Adding clarity relating to: #66959 (comment)

@ijjk ijjk added created-by: Next.js Docs team PRs by the Docs team. Documentation Related to Next.js' official documentation. labels Jul 1, 2024
@delbaoliveira delbaoliveira requested a review from samcx July 1, 2024 13:51
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edit!

The part that's still confusing → "additional iconography other than the favicon"—is this related to all files that are not the ones listed here → https://nextjs.org/docs/app/building-your-application/optimizing/metadata#file-based-metadata? If yes, maybe we can add a link to this, and stating these are the only ones we check.

@delbaoliveira
Copy link
Contributor Author

Yes, it's related to the favicon.ico file. Added a link.

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional iconography other than the [favicon]

Isn't this implying that we ignoring almost everything besides the favicon, when it's really we ignore everything except the favicon, icon, and apple-icon (bolded ones we should also mention)?

Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lfgtm:!

@samcx samcx merged commit 3a852b5 into canary Jul 17, 2024
50 checks passed
@samcx samcx deleted the docs-8dg2 branch July 17, 2024 08:41
@github-actions github-actions bot added the locked label Aug 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js Docs team PRs by the Docs team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants