-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update note on Next.js ignoring CRA files #67346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edit!
The part that's still confusing → "additional iconography other than the favicon"—is this related to all files that are not the ones listed here → https://nextjs.org/docs/app/building-your-application/optimizing/metadata#file-based-metadata? If yes, maybe we can add a link to this, and stating these are the only ones we check.
docs/02-app/01-building-your-application/11-upgrading/05-from-create-react-app.mdx
Outdated
Show resolved
Hide resolved
…create-react-app.mdx
Yes, it's related to the favicon.ico file. Added a link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additional iconography other than the [favicon]
Isn't this implying that we ignoring almost everything besides the favicon
, when it's really we ignore everything except the favicon, icon, and apple-icon (bolded ones we should also mention)?
docs/02-app/01-building-your-application/11-upgrading/05-from-create-react-app.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding clarity relating to: #66959 (comment)