-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Label React syncs in GitHub with type: react-sync
#67628
Label React syncs in GitHub with type: react-sync
#67628
Conversation
latest RCs have considerably diverged from rc.0
by keeping the version in a dedicated file that we can use to label PRs via `labeler.json`. Makes it easier to search for React syncs in GitHub. Since PRs are created manually, using the PR title for searching may not work all the time. There's still a possibility that people don't use the sync script but why would you do that? Even on manual updates they may stumble over `.react-version` and update it.
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
type: react-sync
Failing test suitesCommit: a4c50b5
Expand output● app dir - rsc basics › next internal shared context › should not error if just load next/navigation module in pages/api
● app dir - rsc basics › next internal shared context › should not error if just load next/router module in app page
● app dir - rsc basics › should correctly render page returning null
● app dir - rsc basics › should correctly render component returning null
● app dir - rsc basics › should correctly render layout returning null
● app dir - rsc basics › should correctly render page returning undefined
● app dir - rsc basics › should correctly render component returning undefined
● app dir - rsc basics › should correctly render layout returning undefined
● app dir - rsc basics › should handle named client components imported as page
● app dir - rsc basics › should handle client components imported as namespace
● app dir - rsc basics › should render server components correctly
● app dir - rsc basics › should reuse the inline flight response without sending extra requests
● app dir - rsc basics › should support multi-level server component imports
● app dir - rsc basics › should create client reference successfully for all file conventions
● app dir - rsc basics › should be able to navigate between rsc routes
● app dir - rsc basics › should handle streaming server components correctly
● app dir - rsc basics › should track client components in dynamic imports
● app dir - rsc basics › should support next/link in server components
● app dir - rsc basics › should link correctly with next/link without mpa navigation to the page
● app dir - rsc basics › should escape streaming data correctly
● app dir - rsc basics › should render built-in 404 page for missing route if pagesDir is not presented
● app dir - rsc basics › should suspense next/legacy/image in server components
● app dir - rsc basics › should suspense next/image in server components
● app dir - rsc basics › should handle various kinds of exports correctly
● app dir - rsc basics › should support native modules in server component
● app dir - rsc basics › should resolve different kinds of components correctly
● app dir - rsc basics › should render initial styles of css-in-js in nodejs SSR correctly
● app dir - rsc basics › should render initial styles of css-in-js in edge SSR correctly
● app dir - rsc basics › should render css-in-js suspense boundary correctly
● app dir - rsc basics › should stick to the url without trailing /page suffix
● app dir - rsc basics › should support streaming for flight response
● app dir - rsc basics › should support partial hydration with inlined server data
● app dir - rsc basics › should not apply rsc syntax checks in pages/api
● app dir - rsc basics › should not use bundled react for pages with app
● app dir - rsc basics › should use canary react for app
● app dir - rsc basics › should be able to call legacy react-dom/server APIs in client components
● app dir - rsc basics › should support partial hydration with inlined server data in browser
● app dir - rsc basics › should generate edge SSR manifests for Node.js
● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling ppr
● app dir - rsc basics › react@experimental › should opt into the react@experimental when enabling taint
Read more about building and testing Next.js in contributing.md.
Expand output● app dir - dynamic error trace › should show the error trace
Read more about building and testing Next.js in contributing.md.
Expand output● module layer › with server-only in server targets › should render routes marked with restriction marks without errors /api/default-edge
● module layer › with server-only in server targets › should render routes marked with restriction marks without errors /api/server-only-edge
● module layer › with server-only in server targets › should contain client react exports for pages api
Read more about building and testing Next.js in contributing.md. |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
buildDuration | 18.3s | 17.2s | N/A |
buildDurationCached | 8.3s | 6.8s | N/A |
nodeModulesSize | 354 MB | 344 MB | N/A |
nextStartRea..uration (ms) | 410ms | 406ms | N/A |
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
2f28e317-HASH.js gzip | 51.7 kB | 51.7 kB | N/A |
6708-HASH.js gzip | 5.05 kB | 5.06 kB | N/A |
6832.HASH.js gzip | 169 B | 169 B | ✓ |
7641-HASH.js gzip | 35.8 kB | 36.1 kB | |
framework-HASH.js gzip | 56.7 kB | 56.7 kB | ✓ |
main-app-HASH.js gzip | 220 B | 220 B | ✓ |
main-HASH.js gzip | 32.3 kB | 32.3 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 92.9 kB | 93.2 kB |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
_app-HASH.js gzip | 194 B | 193 B | N/A |
_error-HASH.js gzip | 192 B | 192 B | ✓ |
amp-HASH.js gzip | 511 B | 512 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 2.52 kB | 2.52 kB | ✓ |
edge-ssr-HASH.js gzip | 266 B | 265 B | N/A |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 389 B | 390 B | N/A |
image-HASH.js gzip | 4.26 kB | 4.26 kB | N/A |
index-HASH.js gzip | 268 B | 269 B | N/A |
link-HASH.js gzip | 2.69 kB | 2.69 kB | N/A |
routerDirect..HASH.js gzip | 327 B | 328 B | N/A |
script-HASH.js gzip | 394 B | 393 B | N/A |
withRouter-HASH.js gzip | 323 B | 324 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 2.82 kB | 2.82 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
_buildManifest.js gzip | 482 B | 482 B | ✓ |
Overall change | 482 B | 482 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
index.html gzip | 521 B | 522 B | N/A |
link.html gzip | 537 B | 537 B | ✓ |
withRouter.html gzip | 519 B | 517 B | N/A |
Overall change | 537 B | 537 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
edge-ssr.js gzip | 126 kB | 126 kB | N/A |
page.js gzip | 166 kB | 167 kB | |
Overall change | 166 kB | 167 kB |
Middleware size
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 660 B | 658 B | N/A |
middleware-r..fest.js gzip | 156 B | 156 B | ✓ |
middleware.js gzip | 29.5 kB | 29.5 kB | N/A |
edge-runtime..pack.js gzip | 1.03 kB | 1.03 kB | ✓ |
Overall change | 1.18 kB | 1.18 kB | ✓ |
Next Runtimes Overall increase ⚠️
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
app-page-exp...dev.js gzip | 183 kB | 183 kB | N/A |
app-page-exp..prod.js gzip | 112 kB | 112 kB | |
app-page-tur..prod.js gzip | 123 kB | 123 kB | |
app-page-tur..prod.js gzip | 118 kB | 119 kB | |
app-page.run...dev.js gzip | 178 kB | 178 kB | N/A |
app-page.run..prod.js gzip | 108 kB | 109 kB | |
app-route-ex...dev.js gzip | 23.3 kB | 23.2 kB | N/A |
app-route-ex..prod.js gzip | 18.7 kB | 18.7 kB | N/A |
app-route-tu..prod.js gzip | 18.7 kB | 18.7 kB | N/A |
app-route-tu..prod.js gzip | 18.6 kB | 18.6 kB | N/A |
app-route.ru...dev.js gzip | 24.6 kB | 24.4 kB | N/A |
app-route.ru..prod.js gzip | 18.6 kB | 18.6 kB | N/A |
pages-api-tu..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
pages-api.ru..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
pages-turbo...prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
pages.runtim...dev.js gzip | 22.1 kB | 22.2 kB | N/A |
pages.runtim..prod.js gzip | 21.6 kB | 21.6 kB | ✓ |
server.runti..prod.js gzip | 51.7 kB | 51.7 kB | N/A |
Overall change | 533 kB | 536 kB |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js sebbie/07-10-label_react_syncs_in_github | Change | |
---|---|---|---|
0.pack gzip | 1.68 MB | 1.68 MB | |
index.pack gzip | 132 kB | 132 kB | N/A |
Overall change | 1.68 MB | 1.68 MB |
Diff details
Diff for page.js
Diff too large to display
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for image-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[8358],
{
- /***/ 786: /***/ (
+ /***/ 5233: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(3801);
+ return __webpack_require__(9176);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 3637: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8097: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -40,15 +40,15 @@
__webpack_require__(7825)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(3265)
+ __webpack_require__(9098)
);
- const _getimgprops = __webpack_require__(8486);
- const _imageconfig = __webpack_require__(3712);
- const _imageconfigcontextsharedruntime = __webpack_require__(7557);
- const _warnonce = __webpack_require__(1605);
- const _routercontextsharedruntime = __webpack_require__(1428);
+ const _getimgprops = __webpack_require__(662);
+ const _imageconfig = __webpack_require__(913);
+ const _imageconfigcontextsharedruntime = __webpack_require__(8877);
+ const _warnonce = __webpack_require__(2589);
+ const _routercontextsharedruntime = __webpack_require__(7086);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5869)
+ __webpack_require__(4529)
);
// This is replaced by webpack define plugin
const configEnv = {
@@ -376,7 +376,7 @@
/***/
},
- /***/ 8486: /***/ (
+ /***/ 662: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -392,9 +392,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(1605);
- const _imageblursvg = __webpack_require__(3942);
- const _imageconfig = __webpack_require__(3712);
+ const _warnonce = __webpack_require__(2589);
+ const _imageblursvg = __webpack_require__(7408);
+ const _imageconfig = __webpack_require__(913);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -766,7 +766,7 @@
/***/
},
- /***/ 3942: /***/ (__unused_webpack_module, exports) => {
+ /***/ 7408: /***/ (__unused_webpack_module, exports) => {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -821,7 +821,7 @@
/***/
},
- /***/ 143: /***/ (
+ /***/ 9249: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -848,10 +848,10 @@
},
});
const _interop_require_default = __webpack_require__(1478);
- const _getimgprops = __webpack_require__(8486);
- const _imagecomponent = __webpack_require__(3637);
+ const _getimgprops = __webpack_require__(662);
+ const _imagecomponent = __webpack_require__(8097);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5869)
+ __webpack_require__(4529)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -883,7 +883,7 @@
/***/
},
- /***/ 5869: /***/ (__unused_webpack_module, exports) => {
+ /***/ 4529: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -918,7 +918,7 @@
/***/
},
- /***/ 3801: /***/ (
+ /***/ 9176: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -935,8 +935,8 @@
// EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-a26e3f403e-20240611/node_modules/react/jsx-runtime.js
var jsx_runtime = __webpack_require__(4042);
- // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-a26e3f403e-20240611__7vtiisoyzrp2napaibczsgpnpa/node_modules/next/image.js
- var next_image = __webpack_require__(5197);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-a26e3f403e-20240611__chpopztf5yn4sxej5uzxhihd6q/node_modules/next/image.js
+ var next_image = __webpack_require__(7012);
var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ const nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
@@ -966,12 +966,12 @@
/***/
},
- /***/ 5197: /***/ (
+ /***/ 7012: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(143);
+ module.exports = __webpack_require__(9249);
/***/
},
@@ -981,7 +981,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
- __webpack_exec__(786)
+ __webpack_exec__(5233)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;
Diff for 2f28e317-HASH.js
Diff too large to display
Diff for 7641-HASH.js
Diff too large to display
Diff for main-HASH.js
Diff too large to display
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js
Diff too large to display
Diff for app-route-ex..ntime.dev.js
Diff too large to display
Diff for app-route-ex..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route-tu..time.prod.js
Diff too large to display
Diff for app-route.runtime.dev.js
Diff too large to display
Diff for app-route.ru..time.prod.js
Diff too large to display
Diff for pages.runtime.dev.js
Diff too large to display
Diff for server.runtime.prod.js
Diff too large to display
801d7c7
to
abbf412
Compare
Replaced by #67710 |
by keeping the version in a dedicated file that we can use to label PRs via
labeler.json
.Makes it easier to search for React syncs in GitHub.
Since PRs are created manually, using the PR title for searching may not work all the time.
There's still a possibility that people don't use the sync script but why would you do that?
Even on manual updates they may stumble over
.react-version
and update it.Test plan
Yolo, I guess? The action runs on
pull_request_target
i.e. not on this branch so it doesn't get changes. We'll see if it works on subsequent syncs.