Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t show long internal Rust stack traces to users #67678

Merged
merged 14 commits into from
Jul 16, 2024
Merged

Don’t show long internal Rust stack traces to users #67678

merged 14 commits into from
Jul 16, 2024

Commits on Jul 11, 2024

  1. Don’t show long internal Rust stack traces to users 

    This:

- Writes Turbopack internal errors to a file, `.next/fatal.log`
	- [ ] Automatically truncate this file to prevent it from growing infinitely
- Shows a simplified message to users when an internal Turbopack error occurs, directing them to file an issue with the content of the log
- Adds a panic handler on the Rust side in release builds that similarly shows a simplified message
    @wbinnssmith
    wbinnssmith committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f18d94a View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    81daee7 View commit details
    Browse the repository at this point in the history

  2. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    45c242f View commit details
    Browse the repository at this point in the history

  3. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fa4f390 View commit details
    Browse the repository at this point in the history

  4. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8d52483 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    379eda4 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Merge remote-tracking branch 'origin/canary' into wbinnssmith/dont-sh… 

    …ow-rust-stacktraces
    @wbinnssmith
    wbinnssmith committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5039e7c View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4cd3e49 View commit details
    Browse the repository at this point in the history

  2. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d8c8afe View commit details
    Browse the repository at this point in the history

  3. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    3bfcef8 View commit details
    Browse the repository at this point in the history

  4. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    edfe0d4 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/canary' into wbinnssmith/dont-sh… 

    …ow-rust-stacktraces
    @wbinnssmith
    wbinnssmith committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    01017c2 View commit details
    Browse the repository at this point in the history

  6. fixup! Don’t show long internal Rust stack traces to users

    @wbinnssmith
    wbinnssmith committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    eacbf2f View commit details
    Browse the repository at this point in the history

  7. Update packages/next-swc/crates/napi/src/lib.rs 

    Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>
    @wbinnssmith @bgw
    wbinnssmith and bgw committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fd31b6c View commit details
    Browse the repository at this point in the history