Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add next.config.ts #67773

Merged
merged 10 commits into from
Jul 17, 2024
Merged

docs: add next.config.ts #67773

merged 10 commits into from
Jul 17, 2024

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jul 15, 2024 •
edited
Loading

Add documentation for next.config.ts.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Jul 15, 2024
@devjiwonchoi
Copy link
Member Author

Please take a look at L:116:

Avoid using new JavaScript features not available in your target Node.js version. next.config.js will not be parsed by Webpack, Babel or TypeScript.

I think we need better phrasing here, maybe just remove TypeScript?

@devjiwonchoi devjiwonchoi marked this pull request as ready for review July 15, 2024 12:09
delbaoliveira
delbaoliveira reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jiwon. In the next.config.js page, should we list all the available file types?

docs/02-app/01-building-your-application/07-configuring/01-typescript.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/07-configuring/01-typescript.mdx Outdated Show resolved Hide resolved
docs/02-app/01-building-your-application/07-configuring/01-typescript.mdx Outdated Show resolved Hide resolved
@delbaoliveira
Copy link
Contributor

I think we need better phrasing here, maybe just remove TypeScript?

Yes, agreed 👍🏼

devjiwonchoi and others added 2 commits July 15, 2024 22:31
@devjiwonchoi @delbaoliveira
Update docs/02-app/01-building-your-application/07-configuring/01-typ…
7b93c64 
…escript.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@devjiwonchoi @delbaoliveira
Update docs/02-app/01-building-your-application/07-configuring/01-typ…
ae7a5a5 
…escript.mdx

Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 15, 2024 •
edited
Loading

All broken links are now fixed, thank you!

@devjiwonchoi devjiwonchoi requested a review from eps1lon July 16, 2024 10:03
@devjiwonchoi devjiwonchoi enabled auto-merge (squash) July 17, 2024 06:50
@devjiwonchoi devjiwonchoi merged commit 37f3a91 into canary Jul 17, 2024
54 checks passed
@devjiwonchoi devjiwonchoi deleted the docs/next-config-ts branch July 17, 2024 06:51
@github-actions github-actions bot added the locked label Aug 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delbaoliveira delbaoliveira delbaoliveira approved these changes

@leerob leerob Awaiting requested review from leerob

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devjiwonchoi @delbaoliveira @eps1lon @ijjk