Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Updated the example of catch all routes to utilize the App Router #68270

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

niketchandivade
Copy link
Contributor

This PR updates the catch-all-routes example to use the App Router. Here are the changes that have been made:

  • Renamed the "pages" folder to the "app" folder.
  • Updated the routing for /, /about, and /post/[...slug] files to align with the App Router.
  • Added the layout.tsx file as part of the App Router.
  • Renamed used of next/router instead of used params
  • Updated the package.json file.
  • Updated the Readme file.

CC @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Jul 29, 2024
@ijjk
Copy link
Member

ijjk commented Jul 29, 2024

Allow CI Workflow Run

  • approve CI run for commit: 3b43423

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@samcx samcx self-requested a review July 29, 2024 19:43
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR!

:lgtm:

@samcx samcx enabled auto-merge (squash) July 29, 2024 19:44
@samcx samcx merged commit 242dc7e into vercel:canary Jul 29, 2024
34 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants