Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async dynamic client modules in graph traversal #69202

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix async dynamic client modules in graph traversal #69202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions turbopack/crates/turbopack-ecmascript/src/global_module_id_strategy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,12 +144,19 @@ pub async fn children_modules_idents(
modules_idents.insert(ident_str, hash);
}
ReferencedModule::AsyncLoaderModule(async_loader_module) => {
let async_loader_ident = async_loader_module
let loader_ident = async_loader_module
.ident()
.with_modifier(Vc::cell("async loader".into()));
let ident_str = async_loader_ident.to_string().await?.clone_value();
let hash = hash_xxh3_hash64(&ident_str);
modules_idents.insert(ident_str, hash);
let loader_ident_str = loader_ident.to_string().await?.clone_value();
let loader_hash = hash_xxh3_hash64(&loader_ident_str);
modules_idents.insert(loader_ident_str, loader_hash);

let loaded_client_ident = async_loader_module
.ident()
.with_layer(Vc::cell("app-client".into()));
let loaded_client_ident_str = loaded_client_ident.to_string().await?.clone_value();
let loaded_client_hash = hash_xxh3_hash64(&loaded_client_ident_str);
modules_idents.insert(loaded_client_ident_str, loaded_client_hash);
}
}
}
Expand Down
Loading