Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support React 18 in Pages Router #69484

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Support React 18 in Pages Router #69484

merged 6 commits into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. Support React 18 in Pages router

    @eps1lon @ztanner
    eps1lon authored and ztanner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b6efb97 View commit details
    Browse the repository at this point in the history

  2. Fallback to react-dom/server.browser in Pages router if Edge versio… 

    …n is not available

`react-dom/server.edge` is not available in React 18.
We were using `.browser` before when we were on React 18 so this should be safe.
    @eps1lon @ztanner
    eps1lon authored and ztanner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    48025f9 View commit details
    Browse the repository at this point in the history

  3. Only support React 18 in Pages router 

    Once 19 is stable we can revisit.
We should start work on this now since it's not trivial.
    @eps1lon @ztanner
    eps1lon authored and ztanner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e530069 View commit details
    Browse the repository at this point in the history

  4. Ensure merging refs does not trigger warnings in React 18 

    test plan:
- link-ref-app
- link-ref-pages
    @eps1lon @ztanner
    eps1lon authored and ztanner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e8ef70e View commit details
    Browse the repository at this point in the history

  5. re-add hydration support to React 18 errors (#69757) 

    Re-lands hydration support for React 18 errors by reverting some things
that were part of #65058. Annotated specific parts with comments.
    @ztanner
    ztanner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f27d615 View commit details
    Browse the repository at this point in the history

  6. fix erroneous async component in integration test (#69760) 

    This component is used in Pages which doesn't support async components.
It silently worked because React 19 was used in pages but breaks in
React 18.
    @ztanner
    ztanner committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2195a10 View commit details
    Browse the repository at this point in the history