Reapply "validate path lengths before writes and attempt to eagerly c… #69569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlyon
force-pushed
the
arlyon/attempt-fix-too-long-file
branch
3 times, most recently
from
fa35e58
to
7890120
Compare
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for page.jsDiff too large to display Diff for middleware.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display Diff for image-HASH.js@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
[8358],
{
- /***/ 8908: /***/ (
+ /***/ 8176: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(2111);
+ return __webpack_require__(934);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 6308: /***/ (module, exports, __webpack_require__) => {
+ /***/ 5057: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -30,8 +30,8 @@
return Image;
},
});
- const _interop_require_default = __webpack_require__(9608);
- const _interop_require_wildcard = __webpack_require__(4856);
+ const _interop_require_default = __webpack_require__(4345);
+ const _interop_require_wildcard = __webpack_require__(2874);
const _jsxruntime = __webpack_require__(5815);
const _react = /*#__PURE__*/ _interop_require_wildcard._(
__webpack_require__(6180)
@@ -40,17 +40,17 @@
__webpack_require__(1955)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(2383)
+ __webpack_require__(7163)
);
- const _getimgprops = __webpack_require__(5640);
- const _imageconfig = __webpack_require__(2758);
- const _imageconfigcontextsharedruntime = __webpack_require__(899);
- const _warnonce = __webpack_require__(3878);
- const _routercontextsharedruntime = __webpack_require__(869);
+ const _getimgprops = __webpack_require__(5447);
+ const _imageconfig = __webpack_require__(1650);
+ const _imageconfigcontextsharedruntime = __webpack_require__(1953);
+ const _warnonce = __webpack_require__(5054);
+ const _routercontextsharedruntime = __webpack_require__(4445);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(6501)
+ __webpack_require__(7406)
);
- const _usemergedref = __webpack_require__(3994);
+ const _usemergedref = __webpack_require__(3303);
// This is replaced by webpack define plugin
const configEnv = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
/***/
},
- /***/ 3994: /***/ (module, exports, __webpack_require__) => {
+ /***/ 3303: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -440,7 +440,7 @@
/***/
},
- /***/ 5640: /***/ (
+ /***/ 5447: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -456,9 +456,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(3878);
- const _imageblursvg = __webpack_require__(4317);
- const _imageconfig = __webpack_require__(2758);
+ const _warnonce = __webpack_require__(5054);
+ const _imageblursvg = __webpack_require__(1731);
+ const _imageconfig = __webpack_require__(1650);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -830,7 +830,7 @@
/***/
},
- /***/ 4317: /***/ (__unused_webpack_module, exports) => {
+ /***/ 1731: /***/ (__unused_webpack_module, exports) => {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -885,7 +885,7 @@
/***/
},
- /***/ 8580: /***/ (
+ /***/ 9833: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -911,11 +911,11 @@
return getImageProps;
},
});
- const _interop_require_default = __webpack_require__(9608);
- const _getimgprops = __webpack_require__(5640);
- const _imagecomponent = __webpack_require__(6308);
+ const _interop_require_default = __webpack_require__(4345);
+ const _getimgprops = __webpack_require__(5447);
+ const _imagecomponent = __webpack_require__(5057);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(6501)
+ __webpack_require__(7406)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -947,7 +947,7 @@
/***/
},
- /***/ 6501: /***/ (__unused_webpack_module, exports) => {
+ /***/ 7406: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -982,7 +982,7 @@
/***/
},
- /***/ 2111: /***/ (
+ /***/ 934: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -999,8 +999,8 @@
// EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-7771d3a7-20240827/node_modules/react/jsx-runtime.js
var jsx_runtime = __webpack_require__(5815);
- // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-7771d3a7-20240827_re_h4bgdqagqtli4q7bnw2ajnn4vm/node_modules/next/image.js
- var next_image = __webpack_require__(1878);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-7771d3a7-20240827_re_qz7eh3ruj3cscolfxbcb265hza/node_modules/next/image.js
+ var next_image = __webpack_require__(7649);
var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ const nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
@@ -1030,12 +1030,12 @@
/***/
},
- /***/ 1878: /***/ (
+ /***/ 7649: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(8580);
+ module.exports = __webpack_require__(9833);
/***/
},
@@ -1045,7 +1045,7 @@
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
/******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
- __webpack_exec__(8908)
+ __webpack_exec__(8176)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 5867-HASH.jsDiff too large to display Diff for main-HASH.jsDiff too large to display Diff for app-page-exp..ntime.dev.jsfailed to diffDiff for app-page-exp..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page.runtime.dev.jsDiff too large to display Diff for app-page.runtime.prod.jsDiff too large to display Diff for app-route-ex..ntime.dev.jsDiff too large to display Diff for app-route-ex..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route.runtime.dev.jsDiff too large to display Diff for app-route.ru..time.prod.jsDiff too large to display Diff for server.runtime.prod.jsDiff too large to display |
arlyon
force-pushed
the
arlyon/attempt-fix-too-long-file
branch
2 times, most recently
from
12a0fed
to
f6caaa2
Compare
arlyon
force-pushed
the
arlyon/attempt-fix-too-long-file
branch
from
f6caaa2
to
9b81a61
Compare
bgw
approved these changes
Sep 4, 2024
bgw
reviewed
Sep 4, 2024
| @@ -72,6 +72,80 @@ use crate::{ | |||
| rope::{Rope, RopeReader}, | |||
| }; | |||
|
|
|||
| pub const MAX_FILE_NAME_LENGTH_UNIX: usize = 255; | |||
There was a problem hiding this comment.
Is this going to generate compiler warnings on windows about dead code?
If so, I'd just inline the constant inside of validate_path_length_inner alongside MAX_PATH_LENGTH
Comment on lines
574
to
579
| let full_path = validate_path_length(&full_path).with_context(|| { | ||
| format!( | ||
| "path length for file {} exceeds max length of filesystem", | ||
| full_path.to_string_lossy() | ||
| ) | ||
| })?; |
There was a problem hiding this comment.
Personally, I'd move this .with_context to line 146 inside of validate_path_length where you call validate_path_length_inner.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #69141 after it got reverted. Turns out there was a GT submit that got lost (along with the associated commit) somehow.