Pass client trace metadata to client in pages router #69620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
lforst
commented
Sep 4, 2024
| @@ -11,14 +11,6 @@ import { RedirectStatusCode } from '../../client/components/redirect-status-code | |||
| import { addPathPrefix } from '../../shared/lib/router/utils/add-path-prefix' | |||
| import type { ClientTraceDataEntry } from '../lib/trace/tracer' | |||
|
|
|||
| export function getTracedMetadata( | |||
There was a problem hiding this comment.
Moved this to the trace utils as a generic place because here it was in the app router code and we also want to use it in the pages router.
lforst
changed the title
Tests Passed |
huozhi
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Building on #64256, this PR forwards client trace metadata from OpenTelemetry to the client, but this time for the Pages router.
Why?
To reduce Telemetry libraries need to do expensive and complicated build-time instrumentation to pass these values to the client.
How?
We are using the ambient OpenTelemetry tracer to collect the data and pass it through the Document.
Resolves getsentry/sentry-javascript#13645