Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve instrumentation docs #69665

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 4, 2024

  • Add more context about multi runtime with instrumentation. Since @vercel/otel works for both edge and nodejs, add basic example of simple case here for users to start with other library
  • Make sure the fetch is either returned or awaited, to ensure the beacons are sent to server

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Sep 4, 2024
Copy link
Member Author

huozhi commented Sep 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @huozhi and the rest of your teammates on Graphite Graphite

@huozhi huozhi marked this pull request as ready for review September 4, 2024 10:49
…on.mdx

Co-authored-by: Lee Robinson <me@leerob.io>
@huozhi huozhi requested a review from leerob September 4, 2024 16:26
huozhi and others added 2 commits September 11, 2024 15:56
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
@huozhi huozhi enabled auto-merge (squash) September 11, 2024 13:57
@huozhi huozhi merged commit d6c88fb into canary Sep 11, 2024
53 checks passed
@huozhi huozhi deleted the 09-04-docs_improve_instrumentation_examples branch September 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants