Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update note on caching and db/orms #69695

Merged
merged 6 commits into from
Sep 4, 2024
Merged

docs: update note on caching and db/orms #69695

merged 6 commits into from
Sep 4, 2024

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Sep 4, 2024 •
edited by ijjk
Loading

fixes: #69694

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Sep 4, 2024
@ijjk
Copy link
Member

ijjk commented Sep 4, 2024

Allow CI Workflow Run

  • approve CI run for commit: 4f93dfd

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Sep 4, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: fd2f49e

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@sommeeeer sommeeeer mentioned this pull request Sep 4, 2024
Closed
ijjk
ijjk approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, unless the ORM has a no-store or similar configured this will not bail from the prerendering handling

@ijjk ijjk enabled auto-merge (squash) September 4, 2024 21:40
ijjk and others added 2 commits September 4, 2024 14:40
@ijjk
Apply suggestions from code review
e7ed608
@ijjk @ztanner
Apply suggestions from code review
cd87db5 
Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
@ijjk ijjk disabled auto-merge September 4, 2024 21:41
@ijjk ijjk changed the title docs: fix #69694 docs: update note on caching and db/orms Sep 4, 2024
@ijjk ijjk enabled auto-merge (squash) September 4, 2024 21:42
@ijjk ijjk mentioned this pull request Sep 4, 2024
Closed
@ijjk ijjk merged commit 258a453 into vercel:canary Sep 4, 2024
38 checks passed
@leerob leerob mentioned this pull request Sep 5, 2024
Merged
leerob added a commit that referenced this pull request Sep 5, 2024
@leerob
docs: fix data fetching with ORM (#69702)
63e0298 
Follow up from #69695.
@sommeeeer sommeeeer deleted the docs-fix branch September 5, 2024 06:05
@LelouBil LelouBil mentioned this pull request Sep 7, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@ztanner ztanner ztanner approved these changes

Assignees
No one assigned
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: fix data fetching with an ORM or db
3 participants
@sommeeeer @ijjk @ztanner