Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document the next/dynamic case with ssr: false option #69741

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 5, 2024

Explain the limitation of ssr: false option of next/dynamic when you use it in sever component. For instance ssr: false requires to work properly inside client components.

Related #69720

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. labels Sep 5, 2024
Copy link
Member Author

huozhi commented Sep 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @huozhi and the rest of your teammates on Graphite Graphite

@huozhi huozhi marked this pull request as ready for review September 5, 2024 16:14
Copy link
Member

@devjiwonchoi devjiwonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick:

How about we use > to make it more stand out? That seem to be convention over the docs.

> **Note:** ...

@huozhi huozhi merged commit 6bf5a8a into canary Sep 6, 2024
53 checks passed
@huozhi huozhi deleted the 09-05-huozhi_docs_refine_next_dynamic_usage branch September 6, 2024 20:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants