Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix esm property def in flight loader (#66990)" #69749

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Sep 5, 2024

This reverts commit 9bb06c5.

This was a sort breaking change that could effect using next/dynamic in server component, when the imported one is client component. Ideally you shouldn't directly return it due to the property access restriction for client reference. We've already provided related codemod for v15 but this might be a bit surprise for users upgrading to the new patch.

Reverted as it's not necessarily part of ESM externals fixes.

Fixes #69720

@ijjk
Copy link
Member

ijjk commented Sep 5, 2024

Tests Passed

@huozhi huozhi force-pushed the huozhi/revert-flight-loader branch from fc1639d to b0996dc Compare September 5, 2024 19:04
@ijjk
Copy link
Member

ijjk commented Sep 5, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
buildDuration 16.4s 14.7s N/A
buildDurationCached 7.9s 6.4s N/A
nodeModulesSize 200 MB 200 MB N/A
nextStartRea..uration (ms) 412ms 410ms N/A
Client Bundles (main, webpack)
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
1103-HASH.js gzip 31.6 kB 31.6 kB N/A
1a9f679d-HASH.js gzip 53.7 kB 53.7 kB N/A
335-HASH.js gzip 5.05 kB 5.05 kB
7953.HASH.js gzip 181 B 181 B
framework-HASH.js gzip 44.9 kB 44.9 kB
main-app-HASH.js gzip 245 B 244 B N/A
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 50.1 kB 50.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
_app-HASH.js gzip 195 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 501 B 506 B N/A
css-HASH.js gzip 323 B 324 B N/A
dynamic-HASH.js gzip 1.82 kB 1.82 kB N/A
edge-ssr-HASH.js gzip 259 B 258 B N/A
head-HASH.js gzip 350 B 352 B N/A
hooks-HASH.js gzip 372 B 371 B N/A
image-HASH.js gzip 4.23 kB 4.23 kB
index-HASH.js gzip 259 B 258 B N/A
link-HASH.js gzip 2.68 kB 2.68 kB N/A
routerDirect..HASH.js gzip 316 B 315 B N/A
script-HASH.js gzip 387 B 387 B
withRouter-HASH.js gzip 311 B 310 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 4.9 kB 4.9 kB
Client Build Manifests
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
_buildManifest.js gzip 483 B 483 B
Overall change 483 B 483 B
Rendered Page Sizes
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
index.html gzip 529 B 528 B N/A
link.html gzip 543 B 540 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
edge-ssr.js gzip 95.4 kB 95.4 kB
page.js gzip 3.07 kB 3.06 kB N/A
Overall change 95.4 kB 95.4 kB
Middleware size
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
middleware-b..fest.js gzip 660 B 659 B N/A
middleware-r..fest.js gzip 156 B 156 B
middleware.js gzip 25.8 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 995 B 995 B
Next Runtimes
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
app-page-exp...dev.js gzip 171 kB 171 kB N/A
app-page-exp..prod.js gzip 98 kB 98 kB N/A
app-page-tur..prod.js gzip 99.8 kB 99.8 kB N/A
app-page-tur..prod.js gzip 94 kB 94 kB N/A
app-page.run...dev.js gzip 145 kB 145 kB N/A
app-page.run..prod.js gzip 92.5 kB 92.5 kB N/A
app-route-ex...dev.js gzip 22 kB 22 kB
app-route-ex..prod.js gzip 15.4 kB 15.4 kB
app-route-tu..prod.js gzip 15.4 kB 15.4 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route.ru...dev.js gzip 21.7 kB 21.7 kB
app-route.ru..prod.js gzip 15.2 kB 15.2 kB
pages-api-tu..prod.js gzip 9.58 kB 9.58 kB
pages-api.ru...dev.js gzip 9.85 kB 9.85 kB
pages-api.ru..prod.js gzip 9.57 kB 9.57 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.2 kB 23.2 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.5 kB 51.5 kB
Overall change 254 kB 254 kB
build cache Overall increase ⚠️
vercel/next.js 14-2-1 vercel/next.js huozhi/revert-flight-loader Change
0.pack gzip 1.6 MB 1.6 MB ⚠️ +824 B
index.pack gzip 114 kB 113 kB N/A
Overall change 1.6 MB 1.6 MB ⚠️ +824 B
Diff details
Diff for middleware.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: b0996dc

@huozhi huozhi changed the title wip Revert "Fix esm property def in flight loader (#66990)" Sep 5, 2024
@huozhi huozhi marked this pull request as ready for review September 5, 2024 19:39
@lubieowoce lubieowoce merged commit a882e6e into 14-2-1 Sep 6, 2024
56 of 61 checks passed
@lubieowoce lubieowoce deleted the huozhi/revert-flight-loader branch September 6, 2024 09:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants