docs: update sizes="any" apply strategy to icons #69975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js team
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devjiwonchoi and the rest of your teammates on |
huozhi
requested changes
Sep 11, 2024
docs/02-app/02-api-reference/02-file-conventions/01-metadata/app-icons.mdx
Outdated
Show resolved
Hide resolved
…pp-icons.mdx Co-authored-by: Jiachi Liu <inbox@huozhi.im>
huozhi
reviewed
Sep 11, 2024
docs/02-app/02-api-reference/02-file-conventions/01-metadata/app-icons.mdx
Outdated
Show resolved
Hide resolved
huozhi
changed the title
…pp-icons.mdx Co-authored-by: Jiachi Liu <inbox@huozhi.im>
devjiwonchoi
commented
Sep 11, 2024
docs/02-app/02-api-reference/02-file-conventions/01-metadata/app-icons.mdx
Outdated
Show resolved
Hide resolved
huozhi
reviewed
Sep 11, 2024
docs/02-app/02-api-reference/02-file-conventions/01-metadata/app-icons.mdx
Outdated
Show resolved
Hide resolved
huozhi
approved these changes
Sep 11, 2024
samcx
approved these changes
Sep 11, 2024
devjiwonchoi
deleted the
09-12-docs_remove_sizes_any_from_favicon.ico
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When adding
app/favicon.ico, thesizesproperty were set to"any"to avoid a browser bug where an.icoicon is favored over.svg. However, we changed the behavior to set the actual size at #53343 but the doc wasn't updated together.How?
Removed the previous explanation and updated that
sizes="any"may be applied if the extension is.svgor the size is not specified.Closes #69553
Closes NDX-284