-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade typescript to 5.6.2 #70038
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @devjiwonchoi and the rest of your teammates on Graphite |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/node@20.12.3, npm/babel-plugin-react-compiler@0.0.0-experimental-6067d4e-20240925 |
Waiting webpack/webpack@fdac11f to be released. |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
buildDuration | 23.2s | 20.5s | N/A |
buildDurationCached | 11.2s | 9.6s | N/A |
nodeModulesSize | 370 MB | 370 MB | |
nextStartRea..uration (ms) | 512ms | 504ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
439.HASH.js gzip | 168 B | 168 B | ✓ |
714-HASH.js gzip | 5.26 kB | 5.26 kB | N/A |
7195-HASH.js gzip | 41.1 kB | 41.1 kB | N/A |
9aaa228b-HASH.js gzip | 52.7 kB | 52.7 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | ✓ |
main-app-HASH.js gzip | 229 B | 230 B | N/A |
main-HASH.js gzip | 32.7 kB | 32.7 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 57.6 kB | 57.6 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
_app-HASH.js gzip | 192 B | 193 B | N/A |
_error-HASH.js gzip | 192 B | 191 B | N/A |
amp-HASH.js gzip | 510 B | 510 B | ✓ |
css-HASH.js gzip | 343 B | 343 B | ✓ |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | N/A |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 365 B | N/A |
hooks-HASH.js gzip | 391 B | 393 B | N/A |
image-HASH.js gzip | 4.41 kB | 4.41 kB | N/A |
index-HASH.js gzip | 268 B | 267 B | N/A |
link-HASH.js gzip | 2.78 kB | 2.78 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 326 B | N/A |
script-HASH.js gzip | 396 B | 395 B | N/A |
withRouter-HASH.js gzip | 324 B | 323 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 1.22 kB | 1.22 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
_buildManifest.js gzip | 751 B | 749 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
index.html gzip | 521 B | 524 B | N/A |
link.html gzip | 537 B | 537 B | ✓ |
withRouter.html gzip | 518 B | 518 B | ✓ |
Overall change | 1.05 kB | 1.05 kB | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
edge-ssr.js gzip | 128 kB | 128 kB | N/A |
page.js gzip | 181 kB | 181 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 666 B | 670 B | N/A |
middleware-r..fest.js gzip | 154 B | 156 B | N/A |
middleware.js gzip | 29.8 kB | 29.8 kB | ✓ |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 30.7 kB | 30.7 kB | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
973-experime...dev.js gzip | 322 B | N/A | N/A |
973.runtime.dev.js gzip | 314 B | N/A | N/A |
app-page-exp...dev.js gzip | 318 kB | 318 kB | N/A |
app-page-exp..prod.js gzip | 125 kB | 125 kB | N/A |
app-page-tur..prod.js gzip | 139 kB | 139 kB | N/A |
app-page-tur..prod.js gzip | 134 kB | 134 kB | N/A |
app-page.run...dev.js gzip | 309 kB | 309 kB | ✓ |
app-page.run..prod.js gzip | 121 kB | 121 kB | N/A |
app-route-ex...dev.js gzip | 33.7 kB | 33.7 kB | ✓ |
app-route-ex..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
app-route-tu..prod.js gzip | 22.3 kB | 22.3 kB | ✓ |
app-route-tu..prod.js gzip | 22.1 kB | 22.1 kB | ✓ |
app-route.ru...dev.js gzip | 35.3 kB | 35.3 kB | ✓ |
app-route.ru..prod.js gzip | 22.1 kB | 22.1 kB | ✓ |
pages-api-tu..prod.js gzip | 9.62 kB | 9.62 kB | ✓ |
pages-api.ru...dev.js gzip | 11.5 kB | 11.5 kB | ✓ |
pages-api.ru..prod.js gzip | 9.61 kB | 9.61 kB | ✓ |
pages-turbo...prod.js gzip | 20.9 kB | 20.9 kB | N/A |
pages.runtim...dev.js gzip | 26.5 kB | 26.5 kB | N/A |
pages.runtim..prod.js gzip | 20.9 kB | 20.9 kB | N/A |
server.runti..prod.js gzip | 57.4 kB | 57.4 kB | N/A |
10-experimen...dev.js gzip | N/A | 319 B | N/A |
10.runtime.dev.js gzip | N/A | 311 B | N/A |
Overall change | 497 kB | 497 kB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js 09-13-chore_upgrade_typescript_to_5.6.2 | Change | |
---|---|---|---|
0.pack gzip | 1.66 MB | 1.66 MB | |
index.pack gzip | 131 kB | 131 kB | N/A |
Overall change | 1.66 MB | 1.66 MB |
Diff details
Diff for page.js
Diff too large to display
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for image-HASH.js
@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
- [8358],
+ [2983],
{
- /***/ 6940: /***/ (
+ /***/ 3633: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(1399);
+ return __webpack_require__(2481);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 896: /***/ (module, exports, __webpack_require__) => {
+ /***/ 8461: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -30,27 +30,27 @@
return Image;
},
});
- const _interop_require_default = __webpack_require__(9608);
- const _interop_require_wildcard = __webpack_require__(4856);
- const _jsxruntime = __webpack_require__(3447);
+ const _interop_require_default = __webpack_require__(1739);
+ const _interop_require_wildcard = __webpack_require__(1474);
+ const _jsxruntime = __webpack_require__(2011);
const _react = /*#__PURE__*/ _interop_require_wildcard._(
- __webpack_require__(2136)
+ __webpack_require__(5067)
);
const _reactdom = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(9472)
+ __webpack_require__(1505)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(6615)
+ __webpack_require__(5208)
);
- const _getimgprops = __webpack_require__(9241);
- const _imageconfig = __webpack_require__(7318);
- const _imageconfigcontextsharedruntime = __webpack_require__(9033);
- const _warnonce = __webpack_require__(3273);
- const _routercontextsharedruntime = __webpack_require__(1828);
+ const _getimgprops = __webpack_require__(4329);
+ const _imageconfig = __webpack_require__(8212);
+ const _imageconfigcontextsharedruntime = __webpack_require__(4366);
+ const _warnonce = __webpack_require__(4772);
+ const _routercontextsharedruntime = __webpack_require__(6055);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5319)
+ __webpack_require__(485)
);
- const _usemergedref = __webpack_require__(5674);
+ const _usemergedref = __webpack_require__(7146);
// This is replaced by webpack define plugin
const configEnv = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
/***/
},
- /***/ 5674: /***/ (module, exports, __webpack_require__) => {
+ /***/ 7146: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -383,7 +383,7 @@
return useMergedRef;
},
});
- const _react = __webpack_require__(2136);
+ const _react = __webpack_require__(5067);
function useMergedRef(refA, refB) {
const cleanupA = (0, _react.useRef)(() => {});
const cleanupB = (0, _react.useRef)(() => {});
@@ -432,7 +432,7 @@
/***/
},
- /***/ 9241: /***/ (
+ /***/ 4329: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -448,9 +448,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(3273);
- const _imageblursvg = __webpack_require__(926);
- const _imageconfig = __webpack_require__(7318);
+ const _warnonce = __webpack_require__(4772);
+ const _imageblursvg = __webpack_require__(6800);
+ const _imageconfig = __webpack_require__(8212);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -823,7 +823,7 @@
/***/
},
- /***/ 926: /***/ (__unused_webpack_module, exports) => {
+ /***/ 6800: /***/ (__unused_webpack_module, exports) => {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -878,7 +878,7 @@
/***/
},
- /***/ 5950: /***/ (
+ /***/ 7413: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -904,11 +904,11 @@
return getImageProps;
},
});
- const _interop_require_default = __webpack_require__(9608);
- const _getimgprops = __webpack_require__(9241);
- const _imagecomponent = __webpack_require__(896);
+ const _interop_require_default = __webpack_require__(1739);
+ const _getimgprops = __webpack_require__(4329);
+ const _imagecomponent = __webpack_require__(8461);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(5319)
+ __webpack_require__(485)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -940,7 +940,7 @@
/***/
},
- /***/ 5319: /***/ (__unused_webpack_module, exports) => {
+ /***/ 485: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -975,7 +975,7 @@
/***/
},
- /***/ 1399: /***/ (
+ /***/ 2481: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -991,10 +991,10 @@
});
// EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-778e1ed2-20240926/node_modules/react/jsx-runtime.js
- var jsx_runtime = __webpack_require__(3447);
- // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-778e1ed2-20240926_re_ebxwuw64rrrjl5g3xvkzbm3k2i/node_modules/next/image.js
- var next_image = __webpack_require__(6771);
- var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
+ var jsx_runtime = __webpack_require__(2011);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-778e1ed2-20240926_re_fh4e5z7xrmfcbklhxaz7wo2zsy/node_modules/next/image.js
+ var next_image = __webpack_require__(9588);
+ var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // ./pages/nextjs.png
/* harmony default export */ const nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
height: 1347,
@@ -1003,7 +1003,7 @@
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAHCAMAAAACh/xsAAAAD1BMVEX////x8fH6+vrb29vo6Oh8o70bAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAH0lEQVR4nGNgwARMjIyMjCAGCzMzMwsTRISJCcRABwAEcAAkLCQfgAAAAABJRU5ErkJggg==",
blurWidth: 8,
blurHeight: 7,
- }; // CONCATENATED MODULE: ./pages/image.js
+ }; // ./pages/image.js
function ImagePage(props) {
return /*#__PURE__*/ (0, jsx_runtime.jsxs)(jsx_runtime.Fragment, {
children: [
@@ -1023,12 +1023,12 @@
/***/
},
- /***/ 6771: /***/ (
+ /***/ 9588: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(5950);
+ module.exports = __webpack_require__(7413);
/***/
},
@@ -1037,8 +1037,8 @@
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
- /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
- __webpack_exec__(6940)
+ /******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
+ __webpack_exec__(3633)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;
Diff for 7195-HASH.js
Diff too large to display
Diff for main-HASH.js
Diff too large to display
Diff for 10-experimen..ntime.dev.js
@@ -0,0 +1,2 @@
+"use strict";exports.id=10,exports.ids=[10],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(module,exports1)=>{function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
+//# sourceMappingURL=10-experimental.runtime.dev.js.map
\ No newline at end of file
Diff for 10.runtime.dev.js
@@ -0,0 +1,2 @@
+"use strict";exports.id=10,exports.ids=[10],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(module,exports1)=>{function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
+//# sourceMappingURL=10.runtime.dev.js.map
\ No newline at end of file
Diff for 973-experime..ntime.dev.js
deleted
Diff for 973.runtime.dev.js
deleted
Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page-tur..time.prod.js
Diff too large to display
Diff for app-page.runtime.dev.js
failed to diff
Diff for app-page.runtime.prod.js
Diff too large to display
Diff for pages-turbo...time.prod.js
Diff too large to display
Diff for pages.runtime.dev.js
Diff too large to display
Diff for pages.runtime.prod.js
Diff too large to display
Diff for server.runtime.prod.js
Diff too large to display
packages/next/src/bundles/webpack/packages/HotModuleReplacement.runtime.js
Show resolved
Hide resolved
packages/next/src/bundles/webpack/packages/JavascriptHotModuleReplacement.runtime.js
Show resolved
Hide resolved
package.json
Outdated
"unfetch": "4.2.0", | ||
"wait-port": "0.2.2", | ||
"webpack": "5.90.0", | ||
"webpack": "5.95.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to bump this? Let's do this separately if required since the bundler is a very integral part of the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error with root webpack type:
Error: ../../node_modules/.pnpm/webpack@5.90.0_@swc+core@1.7.0-nightly-
20240714.1_@swc+helpers@0.5.13_/node_modules/webpack/types.d.ts(12112,2):
error TS2416: Property '[Symbol.iterator]' in type 'SortableSet<T>' is not assignable
to the same property in base type 'Set<T>'.
https://github.com/vercel/next.js/actions/runs/11058324871/job/30724077537#step:8:524
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reorder stack: bump webpack to 5.95.0 -> bumb ts
Superseded by #72311 |
Closes NDX-287