Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): remove version attribute post deprecation #70108

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

JamBalaya56562
Copy link
Contributor

What?

Remove version attribute post deprecation from the all docker compose files.

Why?

For the latest docker compose (i.e docker compose v2), the version attribute has been deprecated.
This is currently a warning when you do docker compose up but in the future would become a requirement.
Version and name top-level elements mention that the version has become obsolete for the latest docker compose.

How?

Remove the version field in the compose files to stop the warning that one may get during docker builds.

Adding or Updating Examples

Similar PR: #68503

@ijjk ijjk added the examples Issue/PR related to examples label Sep 14, 2024
@ijjk
Copy link
Member

ijjk commented Sep 14, 2024

Allow CI Workflow Run

  • approve CI run for commit: b05f1e6

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk merged commit d675e23 into vercel:canary Sep 16, 2024
38 checks passed
@JamBalaya56562 JamBalaya56562 deleted the JamBalaya56562-patch-2 branch September 17, 2024 02:13
@github-actions github-actions bot added the locked label Oct 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants