Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor fixes in the ISR doc #70401

Merged
merged 2 commits into from
Sep 24, 2024
Merged

docs: minor fixes in the ISR doc #70401

merged 2 commits into from
Sep 24, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Sep 24, 2024

  • Fix id to be a string
  • Use const instead of let as common ESLint rules would complain otherwise
  • Add types to tsx files and remove some from jsx

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Sep 24, 2024
@ijjk
Copy link
Member

ijjk commented Sep 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 490a355

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Sep 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 490a355

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk ijjk merged commit 3fb0d87 into vercel:canary Sep 24, 2024
38 checks passed
@github-actions github-actions bot added the locked label Oct 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants