Fix telemetry span duration for request spans #70908
Open
+44
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
dvoytenko
requested changes
Oct 8, 2024
| (span) => { | ||
| if (span) { | ||
| const res = args[1] | ||
| res.end = new Proxy(res.end, { |
There was a problem hiding this comment.
Is there no res.on('end', ...)?
There was a problem hiding this comment.
Correct me if I am wrong, but res.on('end') will not work on Vercel because the underlying lambdas freeze on res.end() which happens before res.on('end').
If that is not the case anymore it would be amazing because it would simplify the code here a lot.
lforst
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 8, 2024
…13904) Drop all spans/transactions emitted by Next.js for pages router API routes because they are currently super buggy with wrong timestamps. Fix pending: vercel/next.js#70908 This is just a bit of prep-work so we can at some point disable the logic where we turn on all Next.js spans and still have high quality data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug where telemetry spans for Pages Router requests are way too short.
Why?
The
handleRequestImplfunction is wrapped withtracer.trace()to trace the duration of Next.js handling a request. Thetracer.trace()function immediately starts a span and ends it when the return value of the passed callback resolves.In the pages router
handleRequestImplmore or less immediately resolves, even though the request is still being processed. The started span is immediately ended, not waiting forres.end(), which should be the actual end timestamp of the span.How?
I adjusted the
tracer.trace()function to take an optionalmanualSpanEndoption, which will make thetracer.trace()function not end the span when the promise resolves. Additionally, we now manually end the request span with theonClosehook.Relates to #64723