Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(javascript): fix wrong javascript code and a typo in link.mdx #71143

Merged
merged 6 commits into from
Oct 12, 2024

Conversation

lumirlumir
Copy link
Contributor

@lumirlumir lumirlumir commented Oct 11, 2024

📚 Improving Documentation

Hello, I've fixed some incorrect javascript code and a typo in link.mdx.

I made a few changes:

### 1. Changed app/blog/page to app/blog/[slug]/page

I believe it is accurate to include [slug] in the path.

2. Added export default

The code block was missing export default, so I added it.

3. Corrected missing punctuation

4. Added 'use client'

I think it is appropriate to add 'use client' because the component uses a client-side hook (useIsAuthed) that relies on client state, which requires the component to be rendered on the client side.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Oct 11, 2024
@ijjk
Copy link
Member

ijjk commented Oct 11, 2024

Allow CI Workflow Run

  • approve CI run for commit: 5e2ab04

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@lumirlumir lumirlumir changed the title docs(javascript): fix wrong javascript code and typo in link.mdx docs(javascript): fix wrong javascript code and a typo in link.mdx Oct 11, 2024
@lumirlumir lumirlumir requested a review from ijjk October 12, 2024 01:20
@ijjk ijjk enabled auto-merge (squash) October 12, 2024 01:47
@ijjk ijjk merged commit 7852586 into vercel:canary Oct 12, 2024
38 checks passed
@lumirlumir lumirlumir deleted the docs-javascript-link-mdx branch October 12, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants