Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore all .env files for create-next-app by default #71890

Closed
wants to merge 1 commit into from

Conversation

k-taro56
Copy link
Contributor

Catch-up #61920.

I have confirmed that the behavior is consistent across all templates

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Oct 26, 2024
@k-taro56 k-taro56 changed the title fix: ignore all .env files for create-next-app by default fix: ignore all .env files for create-next-app by default Oct 26, 2024
samcx added a commit that referenced this pull request Dec 3, 2024
## Description
Catch-up #61920 and #72260.
According to [Default Environment
Variables](https://nextjs.org/docs/app/building-your-application/configuring/environment-variables#default-environment-variables)
docs, all `.env` files are excluded in `.gitignore` by default,
However, empty templates aren't applied.

Similar PR: #71890

Co-authored-by: Sam Ko <sam@vercel.com>
@JamBalaya56562
Copy link
Contributor

Thank you for nice PR.
I have already committed similar PR #73415.

@samcx
Copy link
Member

samcx commented Dec 4, 2024

@k-taro56 Ah looks like we missed this earlier one!

@samcx samcx closed this Dec 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants