Turbopack: use file:// uris for server resources in development #71984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
Tests Passed |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for page.jsDiff too large to display Diff for middleware.jsDiff too large to display Diff for edge-ssr.jsDiff too large to display Diff for image-HASH.js@@ -1,7 +1,7 @@
(self["webpackChunk_N_E"] = self["webpackChunk_N_E"] || []).push([
- [2983],
+ [8358],
{
- /***/ 8916: /***/ (
+ /***/ 8942: /***/ (
__unused_webpack_module,
__unused_webpack_exports,
__webpack_require__
@@ -9,7 +9,7 @@
(window.__NEXT_P = window.__NEXT_P || []).push([
"/image",
function () {
- return __webpack_require__(4209);
+ return __webpack_require__(2864);
},
]);
if (false) {
@@ -18,7 +18,7 @@
/***/
},
- /***/ 9265: /***/ (module, exports, __webpack_require__) => {
+ /***/ 1673: /***/ (module, exports, __webpack_require__) => {
"use strict";
/* __next_internal_client_entry_do_not_use__ cjs */
Object.defineProperty(exports, "__esModule", {
@@ -30,27 +30,27 @@
return Image;
},
});
- const _interop_require_default = __webpack_require__(1739);
- const _interop_require_wildcard = __webpack_require__(1474);
- const _jsxruntime = __webpack_require__(7515);
+ const _interop_require_default = __webpack_require__(9608);
+ const _interop_require_wildcard = __webpack_require__(4856);
+ const _jsxruntime = __webpack_require__(2073);
const _react = /*#__PURE__*/ _interop_require_wildcard._(
- __webpack_require__(7611)
+ __webpack_require__(102)
);
const _reactdom = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(9577)
+ __webpack_require__(8693)
);
const _head = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(1436)
+ __webpack_require__(5838)
);
- const _getimgprops = __webpack_require__(8517);
- const _imageconfig = __webpack_require__(2168);
- const _imageconfigcontextsharedruntime = __webpack_require__(9202);
- const _warnonce = __webpack_require__(6992);
- const _routercontextsharedruntime = __webpack_require__(8155);
+ const _getimgprops = __webpack_require__(5726);
+ const _imageconfig = __webpack_require__(187);
+ const _imageconfigcontextsharedruntime = __webpack_require__(5786);
+ const _warnonce = __webpack_require__(3673);
+ const _routercontextsharedruntime = __webpack_require__(759);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(345)
+ __webpack_require__(2182)
);
- const _usemergedref = __webpack_require__(2806);
+ const _usemergedref = __webpack_require__(9363);
// This is replaced by webpack define plugin
const configEnv = {
deviceSizes: [640, 750, 828, 1080, 1200, 1920, 2048, 3840],
@@ -371,7 +371,7 @@
/***/
},
- /***/ 2806: /***/ (module, exports, __webpack_require__) => {
+ /***/ 9363: /***/ (module, exports, __webpack_require__) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -383,7 +383,7 @@
return useMergedRef;
},
});
- const _react = __webpack_require__(7611);
+ const _react = __webpack_require__(102);
function useMergedRef(refA, refB) {
const cleanupA = (0, _react.useRef)(() => {});
const cleanupB = (0, _react.useRef)(() => {});
@@ -432,7 +432,7 @@
/***/
},
- /***/ 8517: /***/ (
+ /***/ 5726: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -448,9 +448,9 @@
return getImgProps;
},
});
- const _warnonce = __webpack_require__(6992);
- const _imageblursvg = __webpack_require__(1692);
- const _imageconfig = __webpack_require__(2168);
+ const _warnonce = __webpack_require__(3673);
+ const _imageblursvg = __webpack_require__(5499);
+ const _imageconfig = __webpack_require__(187);
const VALID_LOADING_VALUES =
/* unused pure expression or super */ null && [
"lazy",
@@ -824,7 +824,7 @@
/***/
},
- /***/ 1692: /***/ (__unused_webpack_module, exports) => {
+ /***/ 5499: /***/ (__unused_webpack_module, exports) => {
"use strict";
/**
* A shared function, used on both client and server, to generate a SVG blur placeholder.
@@ -879,7 +879,7 @@
/***/
},
- /***/ 4673: /***/ (
+ /***/ 6157: /***/ (
__unused_webpack_module,
exports,
__webpack_require__
@@ -905,11 +905,11 @@
return getImageProps;
},
});
- const _interop_require_default = __webpack_require__(1739);
- const _getimgprops = __webpack_require__(8517);
- const _imagecomponent = __webpack_require__(9265);
+ const _interop_require_default = __webpack_require__(9608);
+ const _getimgprops = __webpack_require__(5726);
+ const _imagecomponent = __webpack_require__(1673);
const _imageloader = /*#__PURE__*/ _interop_require_default._(
- __webpack_require__(345)
+ __webpack_require__(2182)
);
function getImageProps(imgProps) {
const { props } = (0, _getimgprops.getImgProps)(imgProps, {
@@ -941,7 +941,7 @@
/***/
},
- /***/ 345: /***/ (__unused_webpack_module, exports) => {
+ /***/ 2182: /***/ (__unused_webpack_module, exports) => {
"use strict";
Object.defineProperty(exports, "__esModule", {
@@ -976,7 +976,7 @@
/***/
},
- /***/ 4209: /***/ (
+ /***/ 2864: /***/ (
__unused_webpack_module,
__webpack_exports__,
__webpack_require__
@@ -992,10 +992,10 @@
});
// EXTERNAL MODULE: ./node_modules/.pnpm/react@19.0.0-rc-7c8e5e7a-20241101/node_modules/react/jsx-runtime.js
- var jsx_runtime = __webpack_require__(7515);
- // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+main-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-7c8e5e7a-20241101_re_ngsqfltlxii45umrwe6rktuauy/node_modules/next/image.js
- var next_image = __webpack_require__(7265);
- var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // ./pages/nextjs.png
+ var jsx_runtime = __webpack_require__(2073);
+ // EXTERNAL MODULE: ./node_modules/.pnpm/next@file+..+diff-repo+packages+next+next-packed.tgz_react-dom@19.0.0-rc-7c8e5e7a-20241101_re_ay5jspqvpcpk5357qiimbatlya/node_modules/next/image.js
+ var next_image = __webpack_require__(9915);
+ var image_default = /*#__PURE__*/ __webpack_require__.n(next_image); // CONCATENATED MODULE: ./pages/nextjs.png
/* harmony default export */ const nextjs = {
src: "/_next/static/media/nextjs.cae0b805.png",
height: 1347,
@@ -1004,7 +1004,7 @@
"data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAgAAAAHCAMAAAACh/xsAAAAD1BMVEX////x8fH6+vrb29vo6Oh8o70bAAAACXBIWXMAAAsTAAALEwEAmpwYAAAAH0lEQVR4nGNgwARMjIyMjCAGCzMzMwsTRISJCcRABwAEcAAkLCQfgAAAAABJRU5ErkJggg==",
blurWidth: 8,
blurHeight: 7,
- }; // ./pages/image.js
+ }; // CONCATENATED MODULE: ./pages/image.js
function ImagePage(props) {
return /*#__PURE__*/ (0, jsx_runtime.jsxs)(jsx_runtime.Fragment, {
children: [
@@ -1024,12 +1024,12 @@
/***/
},
- /***/ 7265: /***/ (
+ /***/ 9915: /***/ (
module,
__unused_webpack_exports,
__webpack_require__
) => {
- module.exports = __webpack_require__(4673);
+ module.exports = __webpack_require__(6157);
/***/
},
@@ -1038,8 +1038,8 @@
// webpackRuntimeModules
/******/ var __webpack_exec__ = (moduleId) =>
__webpack_require__((__webpack_require__.s = moduleId));
- /******/ __webpack_require__.O(0, [636, 6593, 8792], () =>
- __webpack_exec__(8916)
+ /******/ __webpack_require__.O(0, [2888, 9774, 179], () =>
+ __webpack_exec__(8942)
);
/******/ var __webpack_exports__ = __webpack_require__.O();
/******/ _N_E = __webpack_exports__;Diff for 3073-HASH.jsDiff too large to display Diff for main-HASH.jsDiff too large to display Diff for 10-experimen..ntime.dev.jsdeletedDiff for 10.runtime.dev.jsdeletedDiff for 973-experime..ntime.dev.js@@ -0,0 +1,2 @@
+"use strict";exports.id=973,exports.ids=[973],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(module,exports1)=>{function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
+//# sourceMappingURL=973-experimental.runtime.dev.js.map
\ No newline at end of fileDiff for 973.runtime.dev.js@@ -0,0 +1,2 @@
+"use strict";exports.id=973,exports.ids=[973],exports.modules={"./dist/client/dev/noop-turbopack-hmr.js":(module,exports1)=>{function connect(){}Object.defineProperty(exports1,"__esModule",{value:!0}),Object.defineProperty(exports1,"connect",{enumerable:!0,get:function(){return connect}}),("function"==typeof exports1.default||"object"==typeof exports1.default&&null!==exports1.default)&&void 0===exports1.default.__esModule&&(Object.defineProperty(exports1.default,"__esModule",{value:!0}),Object.assign(exports1.default,exports1),module.exports=exports1.default)}};
+//# sourceMappingURL=973.runtime.dev.js.map
\ No newline at end of fileDiff for app-page-exp..ntime.dev.jsfailed to diffDiff for app-page-exp..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page-tur..time.prod.jsDiff too large to display Diff for app-page.runtime.dev.jsfailed to diffDiff for app-page.runtime.prod.jsDiff too large to display Diff for app-route-ex..ntime.dev.jsDiff too large to display Diff for app-route-ex..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route-tu..time.prod.jsDiff too large to display Diff for app-route.runtime.dev.jsDiff too large to display Diff for app-route.ru..time.prod.jsDiff too large to display Diff for pages-turbo...time.prod.jsDiff too large to display Diff for pages.runtime.dev.jsDiff too large to display Diff for pages.runtime.prod.jsDiff too large to display Diff for server.runtime.prod.jsfailed to diff |
wbinnssmith
force-pushed
the
wbinnssmith/server-file-urls
branch
from
ea95183 to
5f665ed
Compare
|
If you stack it on top of #71940, you should have an easier time asserting in the correct stacks since it'll no longer show the full, absolute path. |
|
or normalizing works as well for now. |
|
Do all generated source maps now include the absolute paths or just the ones for dev? |
wbinnssmith
requested review from
bgw,
sokra and
eps1lon
and removed request for
eps1lon
Just dev. |
wbinnssmith
force-pushed
the
wbinnssmith/server-file-urls
branch
from
5f665ed to
e5da935
Compare
wbinnssmith
changed the base branch from
canary
to
sebbie/10-27-clickable_stack_trace_links_in_logged_terminal_errors
eps1lon
approved these changes
Oct 28, 2024
Comment on lines
+34
to
+46
| '\nError: Boom' + | ||
| '\n at logError (app/rsc-error-log/page.js:2:16)' + | ||
| (isTurbopack | ||
| ? '\n at Page (app/rsc-error-log/page.js:7:2)' | ||
| : // FIXME: Method name should be "Page" | ||
| '\n at logError (app/rsc-error-log/page.js:7:2)') + | ||
| '\n 1 | function logError() {' + | ||
| "\n> 2 | const error = new Error('Boom')" + | ||
| '\n | ^' + | ||
| '\n 3 | console.error(error)' + | ||
| '\n 4 | }' + | ||
| '\n 5 |' + | ||
| '\n' |
eps1lon
force-pushed
the
sebbie/10-27-clickable_stack_trace_links_in_logged_terminal_errors
branch
from
9ccdf4b to
e9e1eff
Compare
wbinnssmith
force-pushed
the
wbinnssmith/server-file-urls
branch
2 times, most recently
from
902e496 to
0990dfe
Compare
eps1lon
force-pushed
the
sebbie/10-27-clickable_stack_trace_links_in_logged_terminal_errors
branch
2 times, most recently
from
0737f9d to
c8f7831
Compare
wbinnssmith
force-pushed
the
wbinnssmith/server-file-urls
branch
2 times, most recently
from
62665f3 to
19d9976
Compare
eps1lon
force-pushed
the
sebbie/10-27-clickable_stack_trace_links_in_logged_terminal_errors
branch
2 times, most recently
from
c6bd19e to
9430f84
Compare
eps1lon
force-pushed
the
sebbie/10-27-clickable_stack_trace_links_in_logged_terminal_errors
branch
from
9430f84 to
679929a
Compare
Base automatically changed from
sebbie/10-27-clickable_stack_trace_links_in_logged_terminal_errors
to
canary
November 1, 2024 15:12
|
@wbinnssmith Landed the base now. Once you rebase, we should be able to land this. |
Follows up from #71489, extending this to sourcemaps for server bundles. Test Plan: - [ ] CI - [x] https://github.com/vercel/next.js/blob/61dbe6fb00885068e7ae89ed397e2112076a4577/test/development/app-dir/source-mapping/README.md
eps1lon
force-pushed
the
wbinnssmith/server-file-urls
branch
from
19d9976 to
cf20441
Compare
stipsan
pushed a commit
to sanity-io/next.js
that referenced
this pull request
Nov 6, 2024
…el#71984) Follows up from vercel#71489, extending this to sourcemaps for server bundles. Test Plan: - [x] CI - [x] https://github.com/vercel/next.js/blob/61dbe6fb00885068e7ae89ed397e2112076a4577/test/development/app-dir/source-mapping/README.md Closes PACK-3348
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from #71489, extending this to sourcemaps for server bundles.
Test Plan:
Closes PACK-3348