Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: polish some README.md #72117

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

JamBalaya56562
Copy link
Contributor

Description

I have corrected some mistakes according to the contribution guide.

  1. Update create-next-app script
  2. Remove redundant new line, space and double colon
  3. readme.mdREADME.md

Adding or Updating Examples

@ijjk ijjk added the examples Issue was opened via the examples template. label Oct 31, 2024
@ijjk
Copy link
Member

ijjk commented Oct 31, 2024

Allow CI Workflow Run

  • approve CI run for commit: 11203a1

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@JamBalaya56562 JamBalaya56562 force-pushed the example-README.md branch 5 times, most recently from 28a0e59 to d74030f Compare November 10, 2024 15:57
Copy link
Member

@samcx samcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@samcx samcx enabled auto-merge (squash) November 13, 2024 18:43
@samcx samcx merged commit 49cba42 into vercel:canary Nov 13, 2024
39 checks passed
gaojude pushed a commit that referenced this pull request Nov 13, 2024
## Description
I have corrected some mistakes according to the [contribution
guide](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md).

1. Update `create-next-app` script
2. Remove redundant new line, space and double colon
3. `readme.md` → `README.md`

### Adding or Updating Examples

- [x] The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- [x] Make sure the linting passes by running `pnpm build && pnpm lint`.
See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

---------

Co-authored-by: Sam Ko <sam@vercel.com>
gaojude pushed a commit that referenced this pull request Nov 13, 2024
## Description
I have corrected some mistakes according to the [contribution
guide](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md).

1. Update `create-next-app` script
2. Remove redundant new line, space and double colon
3. `readme.md` → `README.md`

### Adding or Updating Examples

- [x] The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- [x] Make sure the linting passes by running `pnpm build && pnpm lint`.
See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

---------

Co-authored-by: Sam Ko <sam@vercel.com>
@JamBalaya56562 JamBalaya56562 deleted the example-README.md branch November 13, 2024 23:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants