Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(parallel-routes): update 11-parallel-routes.mdx example for modal closing #72210

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

arfa123
Copy link
Contributor

@arfa123 arfa123 commented Nov 2, 2024

docs(parallel-routes): update 11-parallel-routes.mdx example for modal closing

  • Updated 11-parallel-routes.mdx to replace '...' with null in the page.tsx return statement inside the slot for closing the modal when navigating using Link.
  • Also applied the same change in the default.tsx file to ensure consistent behavior in the example.

image
image

fix(modal-navigation): replace '...' with 'null' for modal closing

- Replaced `'...'` with `'null'` in the `page.tsx` return statement inside the slot for closing the modal when navigating using `Link`.
- Applied the same change in the `default.tsx` file to ensure consistent behavior.
@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 2, 2024
@ijjk
Copy link
Member

ijjk commented Nov 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 52b2a5a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Nov 2, 2024

Allow CI Workflow Run

  • approve CI run for commit: 52b2a5a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@arfa123 arfa123 marked this pull request as draft November 2, 2024 14:04
@arfa123 arfa123 marked this pull request as ready for review November 2, 2024 14:06
@arfa123 arfa123 changed the title fix(docs): update 11-parallel-routes.mdx for modal closing docs(parallel-routes): update 11-parallel-routes.mdx example for modal closing Nov 2, 2024
Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@delbaoliveira delbaoliveira enabled auto-merge (squash) November 7, 2024 09:07
@delbaoliveira delbaoliveira merged commit 856521b into vercel:canary Nov 7, 2024
39 checks passed
@arfa123 arfa123 deleted the patch-2 branch November 7, 2024 09:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants