refactor(turbopack): Use ResolvedVc for turbopack-ecmascript
#72564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
reviewed
Nov 11, 2024
turbopack/crates/turbopack-ecmascript/src/references/esm/export.rs
Outdated
Show resolved
Hide resolved
mischnic
reviewed
Nov 11, 2024
turbopack/crates/turbopack-ecmascript/src/references/esm/base.rs
Outdated
Show resolved
Hide resolved
mischnic
reviewed
Nov 11, 2024
mischnic
reviewed
Nov 11, 2024
mischnic
reviewed
Nov 11, 2024
mischnic
reviewed
Nov 12, 2024
Comment on lines
34
to
+46
| #[turbo_tasks::function] | ||
| pub fn new( | ||
| pub async fn new( | ||
| origin: Vc<Box<dyn ResolveOrigin>>, | ||
| request: Vc<Request>, | ||
| issue_source: Vc<IssueSource>, | ||
| in_try: bool, | ||
| ) -> Vc<Self> { | ||
| Self::cell(CjsAssetReference { | ||
| origin, | ||
| request, | ||
| issue_source, | ||
| ) -> Result<Vc<Self>> { | ||
| Ok(Self::cell(CjsAssetReference { | ||
| origin: origin.to_resolved().await?, | ||
| request: request.to_resolved().await?, | ||
| issue_source: issue_source.to_resolved().await?, | ||
| in_try, | ||
| }) | ||
| })) |
There was a problem hiding this comment.
This is still not using ResolvedVc in the arguments
mischnic
reviewed
Nov 12, 2024
mischnic
reviewed
Nov 12, 2024
turbopack/crates/turbopack-ecmascript/src/manifest/loader_item.rs
Outdated
Show resolved
Hide resolved
mischnic
reviewed
Nov 12, 2024
turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs
Outdated
Show resolved
Hide resolved
mischnic
reviewed
Nov 12, 2024
turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs
Outdated
Show resolved
Hide resolved
mischnic
reviewed
Nov 12, 2024
mischnic
reviewed
Nov 12, 2024
mischnic
reviewed
Nov 12, 2024
turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs
Outdated
Show resolved
Hide resolved
mischnic
reviewed
Nov 12, 2024
turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs
Outdated
Show resolved
Hide resolved
kdy1
added a commit
that referenced
this pull request
Nov 14, 2024
### What? Follow-up for #72564 ### Why? We need to refactor this for future works. ### How? --------- Co-authored-by: Benjamin Woodruff <benjamin.woodruff@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use
ResolvedVcfor struct fields inturbopack-ecmascriptcrateWhy?
Follow-up of #72200, #72382, #72320
How?
Closes PACK-3438