-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Turbopack] fix import.meta.url in monorepo #72612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Tests Passed |
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
buildDuration | 19.1s | 15.9s | N/A |
buildDurationCached | 15s | 12.8s | N/A |
nodeModulesSize | 416 MB | 416 MB | ✓ |
nextStartRea..uration (ms) | 472ms | 471ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
1187-HASH.js gzip | 52.4 kB | 52.4 kB | N/A |
8276.HASH.js gzip | 169 B | 168 B | N/A |
8377-HASH.js gzip | 5.36 kB | 5.36 kB | N/A |
bccd1874-HASH.js gzip | 52.8 kB | 52.8 kB | N/A |
framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
main-app-HASH.js gzip | 233 B | 235 B | N/A |
main-HASH.js gzip | 34.1 kB | 34.1 kB | N/A |
webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
_app-HASH.js gzip | 193 B | 193 B | ✓ |
_error-HASH.js gzip | 193 B | 193 B | ✓ |
amp-HASH.js gzip | 512 B | 510 B | N/A |
css-HASH.js gzip | 343 B | 342 B | N/A |
dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | ✓ |
edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
head-HASH.js gzip | 363 B | 362 B | N/A |
hooks-HASH.js gzip | 393 B | 392 B | N/A |
image-HASH.js gzip | 4.49 kB | 4.49 kB | N/A |
index-HASH.js gzip | 268 B | 268 B | ✓ |
link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
script-HASH.js gzip | 397 B | 397 B | ✓ |
withRouter-HASH.js gzip | 323 B | 326 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 3.59 kB | 3.59 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
_buildManifest.js gzip | 749 B | 746 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
index.html gzip | 522 B | 524 B | N/A |
link.html gzip | 537 B | 537 B | ✓ |
withRouter.html gzip | 518 B | 520 B | N/A |
Overall change | 537 B | 537 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
edge-ssr.js gzip | 129 kB | 129 kB | N/A |
page.js gzip | 206 kB | 206 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 670 B | 666 B | N/A |
middleware-r..fest.js gzip | 155 B | 156 B | N/A |
middleware.js gzip | 31.3 kB | 31.3 kB | N/A |
edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
Overall change | 844 B | 844 B | ✓ |
Next Runtimes
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
274-experime...dev.js gzip | 322 B | 322 B | ✓ |
274.runtime.dev.js gzip | 314 B | 314 B | ✓ |
app-page-exp...dev.js gzip | 359 kB | 359 kB | ✓ |
app-page-exp..prod.js gzip | 129 kB | 129 kB | ✓ |
app-page-tur..prod.js gzip | 142 kB | 142 kB | ✓ |
app-page-tur..prod.js gzip | 137 kB | 137 kB | ✓ |
app-page.run...dev.js gzip | 348 kB | 348 kB | ✓ |
app-page.run..prod.js gzip | 125 kB | 125 kB | ✓ |
app-route-ex...dev.js gzip | 37.5 kB | 37.5 kB | ✓ |
app-route-ex..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.5 kB | 25.5 kB | ✓ |
app-route-tu..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
app-route.ru...dev.js gzip | 39.2 kB | 39.2 kB | ✓ |
app-route.ru..prod.js gzip | 25.4 kB | 25.4 kB | ✓ |
pages-api-tu..prod.js gzip | 9.69 kB | 9.69 kB | ✓ |
pages-api.ru...dev.js gzip | 11.6 kB | 11.6 kB | ✓ |
pages-api.ru..prod.js gzip | 9.68 kB | 9.68 kB | ✓ |
pages-turbo...prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
pages.runtim...dev.js gzip | 27.5 kB | 27.5 kB | ✓ |
pages.runtim..prod.js gzip | 21.7 kB | 21.7 kB | ✓ |
server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
Overall change | 2.44 MB | 2.44 MB | ✓ |
build cache Overall increase ⚠️
vercel/next.js canary | vercel/next.js sokra/import-meta-url-monorepo | Change | |
---|---|---|---|
0.pack gzip | 2.08 MB | 2.08 MB | N/A |
index.pack gzip | 73.5 kB | 74.6 kB | |
Overall change | 73.5 kB | 74.6 kB |
Diff details
Diff for main-HASH.js
Diff too large to display
sokra
changed the title
fix import.meta.url in monorepo
[Turbopack] fix import.meta.url in monorepo
Nov 12, 2024
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
2 times, most recently
from
December 5, 2024 15:37
a99da3b
to
bae00fc
Compare
This was referenced Dec 5, 2024
sokra
force-pushed
the
sokra/fix-monorepo-paths
branch
from
December 5, 2024 15:45
9d3367a
to
f70e8a5
Compare
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
2 times, most recently
from
December 5, 2024 16:10
1a55a49
to
621016a
Compare
sokra
force-pushed
the
sokra/fix-monorepo-paths
branch
from
December 6, 2024 07:53
d1bfcc3
to
8074d4c
Compare
This was referenced Dec 6, 2024
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
from
December 6, 2024 08:18
621016a
to
ffef7cb
Compare
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
from
December 6, 2024 08:54
ffef7cb
to
3d93491
Compare
sokra
force-pushed
the
sokra/fix-monorepo-paths
branch
from
December 9, 2024 07:34
d0f6b28
to
466d6b8
Compare
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
from
December 9, 2024 07:34
3d93491
to
8d96637
Compare
sokra
force-pushed
the
sokra/fix-monorepo-paths
branch
from
December 19, 2024 08:27
466d6b8
to
2b7ca40
Compare
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
2 times, most recently
from
December 19, 2024 10:25
2a29b4d
to
3ac7f43
Compare
sokra
changed the base branch from
sokra/fix-monorepo-paths
to
graphite-base/72612
December 19, 2024 11:56
sokra
force-pushed
the
graphite-base/72612
branch
from
December 19, 2024 11:57
8e343d7
to
53bb90c
Compare
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
from
December 19, 2024 11:57
3ac7f43
to
0eeeafe
Compare
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
from
December 19, 2024 11:58
0eeeafe
to
becc48a
Compare
eps1lon
approved these changes
Dec 19, 2024
sokra
force-pushed
the
sokra/import-meta-url-monorepo
branch
from
December 20, 2024 12:33
becc48a
to
caff3ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
created-by: Turbopack team
PRs by the Turbopack team.
tests
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
fixes the computation of
import.meta.url
inside of monorepos (when the root_path != project_path)How?
We add a new argument to the ChunkingContext that represents the relative path from the output folder to the root of the monorepo. Since they are on different filesystems, we can't compute them from the values alone.
Closes PACK-3679