-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: flake detection should run in both bundlers #72773
ci: flake detection should run in both bundlers #72773
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This reverts commit bd0376d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to parallelize more to avoid these being slow?
I think we'll need to see how it goes -- I picked a beefier test to modify and it finished in dev/start flake detection before prod tests finished. I think the current parallelization often goes under utilized because we typically only see a few test changes per PR, but if this causes problems I'd probably want to split the Turbopack flake detection into a separate job |
Failing test suitesCommit: 108d027
Expand output● app-dir-hmr › filesystem changes › should update server components after navigating to a page with a different runtime
Read more about building and testing Next.js in contributing.md. |
We run flake detection on PRs to help catch flaky tests before they hit canary, but we currently only run flaky test detection in Webpack and not Turbopack. This is problematic because there's sufficient forking logic in tests for the different bundlers & we've seen a high likelihood of a test to flake more frequently in one bundler vs another due to things like differing compilation speeds and differing implementation of core features.
This will add some additional time to this CI job to account for needing to run the tests 6 times, but will hopefully catch things before they become a problem later. I think we could also consider reducing the number of times per bundler to be 2 if it turns out to be adding too much time.
This updates the flake detection job to run the tests multiple times in Turbopack as well.
CI run: https://github.com/vercel/next.js/actions/runs/11822662639/job/32940264160?pr=72773