Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing await, missing type Promise #73088

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

hyungjikim
Copy link
Contributor

Hi, Team.
It seems Promise is missing when defining params type.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Nov 22, 2024
@ijjk
Copy link
Member

ijjk commented Nov 22, 2024

Allow CI Workflow Run

  • approve CI run for commit: fbad00a

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

…ncremental-static-regeneration.mdx

Co-authored-by: Maikel <maikel.van.dort@gmail.com>
@vercel vercel deleted a comment from ijjk Nov 22, 2024
@eps1lon eps1lon added the CI approved Approve running CI for fork label Nov 22, 2024
@eps1lon
Copy link
Member

eps1lon commented Nov 22, 2024

Code is not formatted. pnpm prettier-fix should fix it.

@hyungjikim
Copy link
Contributor Author

Code is not formatted. pnpm prettier-fix should fix it.

Thank you. Prettier applied.

@ijjk ijjk merged commit 27961cf into vercel:canary Nov 22, 2024
39 checks passed
wyattjoh pushed a commit that referenced this pull request Nov 28, 2024
Hi, Team.
It seems Promise is missing when defining params type.

---------

Co-authored-by: hyungji <hj@doodlin.co.kr>
Co-authored-by: Maikel <maikel.van.dort@gmail.com>
@github-actions github-actions bot added the locked label Dec 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants