Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbopack: Single-graph-traversal and migrate next/dynamic #73222

Merged
merged 29 commits into from
Dec 10, 2024
Merged

Turbopack: Single-graph-traversal and migrate next/dynamic #73222

merged 29 commits into from
Dec 10, 2024

Conversation

mischnic
Copy link
Contributor

@mischnic mischnic commented Nov 26, 2024 •
edited
Loading

Closes PACK-3535

  • Adds some infrastructure for the single-graph-traversal stuff, focusing on dev with layout segment optimization for now
  • Migrate next/dynamic collection to it
  • This shouldn't make any observable change to the output

@ijjk ijjk added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Nov 26, 2024
@mischnic mischnic marked this pull request as draft November 26, 2024 18:17
@mischnic Graphite App
Copy link
Contributor Author

mischnic commented Nov 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch from f88f670 to 3cada25 Compare November 26, 2024 18:18
@ijjk
Copy link
Member

ijjk commented Nov 26, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
buildDuration 20s 17.5s N/A
buildDurationCached 16.6s 14.8s N/A
nodeModulesSize 409 MB 409 MB N/A
nextStartRea..uration (ms) 474ms 480ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
index.html gzip 524 B 523 B N/A
link.html gzip 538 B 538 B ✓
withRouter.html gzip 520 B 520 B ✓
Overall change 1.06 kB 1.06 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 127 kB 127 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page-tur..prod.js gzip 135 kB 135 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 122 kB 122 kB ✓
app-route-ex...dev.js gzip 37.1 kB 37.1 kB ✓
app-route-ex..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 24.9 kB 24.9 kB ✓
app-route.ru...dev.js gzip 38.7 kB 38.7 kB ✓
app-route.ru..prod.js gzip 24.9 kB 24.9 kB ✓
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB ✓
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB ✓
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB ✓
pages-turbo...prod.js gzip 21.3 kB 21.3 kB ✓
pages.runtim...dev.js gzip 27 kB 27 kB ✓
pages.runtim..prod.js gzip 21.3 kB 21.3 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.35 MB 2.35 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js mischnic/single-traversal-next-dynamic Change
0.pack gzip 2.03 MB 2.04 MB ⚠️ +3.47 kB
index.pack gzip 144 kB 145 kB ⚠️ +1.06 kB
Overall change 2.18 MB 2.18 MB ⚠️ +4.54 kB
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 65d716f

@ijjk
Copy link
Member

ijjk commented Nov 26, 2024 •
edited
Loading

Tests Passed

@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch 3 times, most recently from ff6d8c4 to 6fdb3cc Compare November 27, 2024 14:29
@mischnic mischnic mentioned this pull request Nov 27, 2024
Merged
@mischnic mischnic added the CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci label Nov 27, 2024
@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch from 6fdb3cc to 9e3c57a Compare November 27, 2024 15:44
@mischnic mischnic marked this pull request as ready for review November 27, 2024 20:04
@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch 3 times, most recently from d140123 to 0378e72 Compare November 28, 2024 15:25
@mischnic mischnic mentioned this pull request Nov 28, 2024
Merged
@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch 7 times, most recently from d2081b4 to 17b6489 Compare December 4, 2024 15:26
@mischnic mischnic requested a review from sokra December 4, 2024 18:46
@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch 2 times, most recently from c325524 to cb05a83 Compare December 5, 2024 12:09
@mischnic mischnic mentioned this pull request Dec 6, 2024
Merged
@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch from cb05a83 to ae17d73 Compare December 9, 2024 14:58
mischnic and others added 26 commits December 10, 2024 12:59
@mischnic
Cleanup
0ccfa63
@wbinnssmith @mischnic
Single graph traversal: collect app and page entries and construct a …
0b07a0d 
…single graph (#73231)

Entry collection is modeled after
https://github.com/vercel/next.js/blob/6f679eef0addac257da440c38d3a5303a763d506/crates/next-api/src/global_module_id_strategy.rs#L19-L23
@mischnic
Filter global graph for page for next/dynamic
744d7bd
@mischnic
Unify SingleModuleGraph creation
72f0e2e
@mischnic
Store page entries for graph
12a3cb6
@mischnic
Rename variable
603ff27
@mischnic
Cleanup, restrict public API, docs
db88187
@mischnic
Use new graph in pages router for next/dynamic
8cb498d
@mischnic
Fix layer check
dd6bba9
@mischnic
Fix types
4f42f4e
@mischnic
Fewer map conversions
a50ff26
@mischnic
Provide graph.traverse_from_entry
e49244d
@mischnic
Instrumentation
0d8ded8
@mischnic
Try to prevent duplicate issues
ce06177
@mischnic
refactor get_module_graph_for_app_without_issues
821ff61
@mischnic
ignore sourcemaps
a30dc4e
@mischnic
ChunkingType::Isolated
0e46216
@mischnic
SingleModuleGraph::traverse_edges_from_entry
ce92067
@mischnic
Walk chunkable references instead
490f37c
@mischnic
Take issues in SingleModuleGraph
a0038dc
@mischnic
Parallel traversal
468e410
@mischnic
SingleModuleGraphBuilderNode::Issues
fbf4845
@mischnic
Add TracedDiGraph
f80a9e0
@mischnic
Fixup ResolvedVc
b9937ba
@mischnic @sokra
Update crates/next-api/src/module_graph.rs
284e4e4 
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
@mischnic
Address review comments
65d716f
@mischnic mischnic force-pushed the mischnic/single-traversal-next-dynamic branch from 75cc7cf to 65d716f Compare December 10, 2024 12:14
@mischnic mischnic merged commit b94dfd0 into canary Dec 10, 2024
114 checks passed
@mischnic mischnic deleted the mischnic/single-traversal-next-dynamic branch December 10, 2024 13:23
@mischnic mischnic mentioned this pull request Dec 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
CI Bypass Graphite Optimization Ignore Graphite CI optimizations, run the full CI suite. https://graphite.dev/docs/stacking-and-ci created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mischnic @ijjk @wbinnssmith @sokra