Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated with-react-foundation example to utilize the App router. #73243

Merged
merged 8 commits into from
Nov 28, 2024
Merged

updated with-react-foundation example to utilize the App router. #73243

merged 8 commits into from
Nov 28, 2024
+0 −201

Conversation

PapatMayuri
Copy link
Contributor

@PapatMayuri PapatMayuri commented Nov 27, 2024 •
edited
Loading

This PR updates the with-react-foundation example for using the App Router.
Here are the changes that have been made:

  • I renamed the pages folder and moved it to the app folder.
  • Added the layout.tsx file as part of the App Router.
  • Moved component folder into app folder.
  • Updated the package.json file.

CC: @samcx

@ijjk ijjk added the examples Issue was opened via the examples template. label Nov 27, 2024
@ijjk
Copy link
Member

ijjk commented Nov 27, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: ac5b6ab

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@PapatMayuri PapatMayuri marked this pull request as ready for review November 27, 2024 06:59
@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/foundation-sites@6.9.0 Transitive: environment, filesystem, shell, unsafe +29 372 MB joeworkman

🚮 Removed packages: npm/foundation-sites@6.8.1

View full report↗︎

@samcx
Copy link
Member

samcx commented Nov 28, 2024

@PapatMayuri Removing this example, since react-foundation hasn't been updated since 2021 the repo has been archived since 2023.

@samcx samcx self-requested a review November 28, 2024 01:29
@samcx samcx enabled auto-merge (squash) November 28, 2024 01:30
@samcx samcx merged commit 7977898 into vercel:canary Nov 28, 2024
39 checks passed
@JamBalaya56562 JamBalaya56562 mentioned this pull request Nov 28, 2024
Merged
samcx added a commit that referenced this pull request Dec 10, 2024
@JamBalaya56562 @samcx
test: update turbopack-dev-examples-manifest (#73230)
58f9df3 
## Summary

At #73211, `with-unstated` example was deleted.
In addition, at #73243 `with-react-foundation` example was removed.
So, I also remove them from
[turbopack-dev-examples-manifest](https://github.com/vercel/next.js/blob/canary/test/turbopack-dev-examples-manifest.json).

CC: @samcx

Co-authored-by: Sam Ko <sam@vercel.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samcx samcx samcx approved these changes

Assignees
No one assigned
Labels
examples Issue was opened via the examples template. locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PapatMayuri @ijjk @samcx