Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move HMR basic test to a separate file #73612

Merged
merged 2 commits into from
Dec 9, 2024
Merged

test: move HMR basic test to a separate file #73612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb1d583
test: move HMR basic test to a separate file
devjiwonchoi Dec 6, 2024
ff4fe3e
delete
devjiwonchoi Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 15 additions & 30 deletions test/development/basic/hmr.test.ts → test/development/basic/hmr/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import { join } from 'path'
import webdriver from 'next-webdriver'
import {
assertHasRedbox,
getBrowserBodyText,
retry,
waitFor,
} from 'next-test-utils'
import { createNext } from 'e2e-utils'
import { NextInstance } from 'e2e-utils'
import { createNext, nextTestSetup } from 'e2e-utils'
import type { NextConfig } from 'next'

describe.each([
Expand All @@ -16,28 +13,20 @@ describe.each([
{ basePath: '/docs', assetPrefix: '' },
{ basePath: '/docs', assetPrefix: '/asset-prefix' },
])('basic HMR, nextConfig: %o', (nextConfig: Partial<NextConfig>) => {
const { basePath } = nextConfig
let next: NextInstance

beforeAll(async () => {
next = await createNext({
files: join(__dirname, 'hmr'),
nextConfig,
patchFileDelay: 500,
})
const { next } = nextTestSetup({
files: __dirname,
nextConfig,
patchFileDelay: 500,
})
afterAll(() => next.destroy())
const { basePath } = nextConfig

it('should have correct router.isReady for auto-export page', async () => {
let browser = await webdriver(next.url, basePath + '/auto-export-is-ready')
let browser = await next.browser(basePath + '/auto-export-is-ready')

expect(await browser.elementByCss('#ready').text()).toBe('yes')
expect(JSON.parse(await browser.elementByCss('#query').text())).toEqual({})

browser = await webdriver(
next.url,
basePath + '/auto-export-is-ready?hello=world'
)
browser = await next.browser(basePath + '/auto-export-is-ready?hello=world')

await retry(async () => {
expect(await browser.elementByCss('#ready').text()).toBe('yes')
Expand All @@ -48,12 +37,12 @@ describe.each([
})

it('should have correct router.isReady for getStaticProps page', async () => {
let browser = await webdriver(next.url, basePath + '/gsp-is-ready')
let browser = await next.browser(basePath + '/gsp-is-ready')

expect(await browser.elementByCss('#ready').text()).toBe('yes')
expect(JSON.parse(await browser.elementByCss('#query').text())).toEqual({})

browser = await webdriver(next.url, basePath + '/gsp-is-ready?hello=world')
browser = await next.browser(basePath + '/gsp-is-ready?hello=world')

await retry(async () => {
expect(await browser.elementByCss('#ready').text()).toBe('yes')
Expand All @@ -68,10 +57,7 @@ describe.each([
const originalContent = await next.readFile(pageName)

try {
const browser = await webdriver(
next.url,
basePath + '/auto-export-is-ready'
)
const browser = await next.browser(basePath + '/auto-export-is-ready')
const outputLength = next.cliOutput.length
await next.patchFile(
pageName,
Expand Down Expand Up @@ -101,9 +87,7 @@ describe.each([
})

it('should reload the page when the server restarts', async () => {
const browser = await webdriver(next.url, basePath + '/hmr/about', {
headless: false,
})
const browser = await next.browser(basePath + '/hmr/about')
await retry(async () => {
expect(await getBrowserBodyText(browser)).toMatch(
/This is the about page/
Expand All @@ -120,12 +104,13 @@ describe.each([
})
})

next = await createNext({
files: join(__dirname, 'hmr'),
const secondNext = await createNext({
files: __dirname,
nextConfig,
forcedPort: next.appPort,
})

await reloadPromise
await secondNext.destroy()
})
})
Loading