support `cause` in Next.js error signals #73665

ztanner · 2024-12-08T21:26:44Z

No description provided.

ztanner · 2024-12-08T21:27:00Z

support cause in Next.js error signals #73665 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2024-12-08T21:32:41Z

Failing test suites

Commit: ca8c5e7

pnpm test-dev-turbo test/development/acceptance/ReactRefreshRequire.test.ts (turbopack)

ReactRefreshRequire > propagates a hot update to closest accepted module
ReactRefreshRequire > propagates hot update to all inverse dependencies

Expand output

● ReactRefreshRequire › propagates a hot update to closest accepted module

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
    "init FooV1",
+   "init FooV1",
    "init BarV3",
  ]

  141 |       `
  142 |     )
> 143 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  144 |       // // FIXME: Metro order:
  145 |       // 'init BarV3',
  146 |       // 'init FooV1',

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:143:63)

● ReactRefreshRequire › propagates hot update to all inverse dependencies

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

  Array [
+   "init RootV1",
    "init MiddleCV2",
    "init RootV1",
  ]

  299 |       `log.push('init MiddleCV2'); export default {};`
  300 |     )
> 301 |     expect(await session.evaluate(() => (window as any).log)).toEqual([
      |                                                               ^
  302 |       'init MiddleCV2',
  303 |       'init RootV1',
  304 |     ])

  at Object.toEqual (development/acceptance/ReactRefreshRequire.test.ts:301:63)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/opentelemetry/client-trace-metadata/client-trace-metadata.test.ts (PPR)

clientTraceMetadata > app router > should inject propagation data for a dynamically server-side-rendered page
clientTraceMetadata > app router > hard loading a dynamic page twice should yield different dynamic trace data
clientTraceMetadata > app router > should only insert the client trace metadata once
clientTraceMetadata > app router > next dev only > should inject propagation data for a statically server-side-rendered page
clientTraceMetadata > app router > next dev only > soft navigating to a dynamic page should not transform previous propagation data
clientTraceMetadata > app router > next dev only > soft navigating to a static page should not transform previous propagation data
clientTraceMetadata > pages router > should inject propagation data for a dynamically server-side-rendered page
clientTraceMetadata > pages router > hard loading a dynamic page twice should yield different dynamic trace data
clientTraceMetadata > pages router > next dev only > should inject propagation data for a statically server-side-rendered page
clientTraceMetadata > pages router > next dev only > soft navigating to a dynamic page should not transform previous propagation data
clientTraceMetadata > pages router > next dev only > soft navigating to a static page should not transform previous propagation data

Expand output

● clientTraceMetadata › app router › should inject propagation data for a dynamically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › app router › hard loading a dynamic page twice should yield different dynamic trace data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › app router › should only insert the client trace metadata once

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › app router › next dev only › should inject propagation data for a statically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › app router › next dev only › soft navigating to a dynamic page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › app router › next dev only › soft navigating to a static page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › pages router › should inject propagation data for a dynamically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › pages router › hard loading a dynamic page twice should yield different dynamic trace data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › pages router › next dev only › should inject propagation data for a statically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › pages router › next dev only › soft navigating to a dynamic page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

● clientTraceMetadata › pages router › next dev only › soft navigating to a static page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  347 |     return setTimeout(() => {
  348 |       reject(
> 349 |         new Error(
      |         ^
  350 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  351 |         )
  352 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:349:9)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/middleware-errors/index.test.ts

middleware - development errors > when throwing while loading the module > renders the error correctly and recovers

Expand output

● middleware - development errors › when throwing while loading the module › renders the error correctly and recovers

Expected no Redbox but found one
header: 1 of 1 error
Next.js (15.0.4-canary.47)
Server Error

Error: booooom!

This error happened while generating the page. Any console logs will be displayed in the terminal window.
description: Error: booooom!
source: middleware.js (3:13) @ eval

  1 |
  2 |       import { NextResponse } from 'next/server'
> 3 |       throw new Error('booooom!')
    |             ^
  4 |       export default function () {
  5 |         return NextResponse.next()
  6 |       }

  253 |       expect(source).not.toContain('//middleware.js')
  254 |       await next.patchFile('middleware.js', `export default function () {}`)
> 255 |       await assertNoRedbox(browser)
      |       ^
  256 |     })
  257 |   })
  258 |

  at Object.<anonymous> (development/middleware-errors/index.test.ts:255:7)

Read more about building and testing Next.js in contributing.md.

pnpm test-dev test/development/acceptance-app/ReactRefreshLogBox.test.ts

ReactRefreshLogBox app default > server component can recover from error thrown in the module

Expand output

● ReactRefreshLogBox app default › server component can recover from error thrown in the module

Expected Redbox but found none

  1060 |
  1061 |       await next.patchFile('index.js', "throw new Error('module error')")
> 1062 |       await session.assertHasRedbox()
       |       ^
  1063 |       await next.patchFile(
  1064 |         'index.js',
  1065 |         'export default function Page() {return <p>hello world</p>}'

  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:1062:7)

Read more about building and testing Next.js in contributing.md.

ijjk · 2024-12-08T21:35:39Z

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
buildDuration	27.3s	24.4s	N/A
buildDurationCached	23.4s	20.9s	N/A
nodeModulesSize	409 MB	409 MB	⚠️ +4.42 kB
nextStartRea..uration (ms)	586ms	578ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
1187-HASH.js gzip	50.2 kB	50.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.3 kB	5.3 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	232 B	235 B	N/A
main-HASH.js gzip	33.8 kB	33.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	513 B	511 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	N/A
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.44 kB	4.43 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	1.75 kB	1.75 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
_buildManifest.js gzip	746 B	747 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
index.html gzip	524 B	521 B	N/A
link.html gzip	537 B	537 B	✓
withRouter.html gzip	520 B	519 B	N/A
Overall change	537 B	537 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	203 kB	203 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
middleware-b..fest.js gzip	668 B	665 B	N/A
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31 kB	31 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	844 B	844 B	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
797-experime...dev.js gzip	322 B	322 B	✓
797.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	322 kB	322 kB	N/A
app-page-exp..prod.js gzip	127 kB	127 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page-tur..prod.js gzip	135 kB	135 kB	✓
app-page.run...dev.js gzip	312 kB	312 kB	N/A
app-page.run..prod.js gzip	122 kB	122 kB	✓
app-route-ex...dev.js gzip	37.1 kB	37.1 kB	✓
app-route-ex..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	24.9 kB	24.9 kB	✓
app-route.ru...dev.js gzip	38.7 kB	38.7 kB	✓
app-route.ru..prod.js gzip	24.9 kB	24.9 kB	✓
pages-api-tu..prod.js gzip	9.56 kB	9.56 kB	✓
pages-api.ru...dev.js gzip	11.4 kB	11.4 kB	✓
pages-api.ru..prod.js gzip	9.56 kB	9.56 kB	✓
pages-turbo...prod.js gzip	21.3 kB	21.3 kB	✓
pages.runtim...dev.js gzip	27 kB	27 kB	✓
pages.runtim..prod.js gzip	21.3 kB	21.3 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	1.72 MB	1.72 MB	✓

build cache

	vercel/next.js canary	vercel/next.js 12-06-support_cause_in_next.js_error_signals	Change
0.pack gzip	2.04 MB	2.04 MB	N/A
index.pack gzip	146 kB	146 kB	N/A
Overall change	0 B	0 B	✓

Diff details

Diff for 1187-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Commit: ca8c5e7

wyattjoh · 2024-12-09T17:54:05Z

test/e2e/app-dir/forbidden/basic/app/cause/page.js

+  try {
+    await verifyAuth()
+  } catch (err) {
+    if (err.cause instanceof SessionExpiredError) {


This doesn't work when there's multiple nested cause correct?

support cause in Next.js error signals

ca8c5e7

ijjk added created-by: Next.js team PRs by the Next.js team. Documentation Related to Next.js' official documentation. tests type: next labels Dec 8, 2024

wyattjoh reviewed Dec 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support `cause` in Next.js error signals #73665

support `cause` in Next.js error signals #73665

ztanner commented Dec 8, 2024

ztanner commented Dec 8, 2024

ijjk commented Dec 8, 2024 •

edited

Loading

ijjk commented Dec 8, 2024

wyattjoh Dec 9, 2024

support cause in Next.js error signals #73665

Are you sure you want to change the base?

support cause in Next.js error signals #73665

Conversation

ztanner commented Dec 8, 2024

ztanner commented Dec 8, 2024

ijjk commented Dec 8, 2024 • edited Loading

Failing test suites

ijjk commented Dec 8, 2024

Stats from current PR

wyattjoh Dec 9, 2024

Choose a reason for hiding this comment

support `cause` in Next.js error signals #73665

support `cause` in Next.js error signals #73665

ijjk commented Dec 8, 2024 •

edited

Loading