Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure pnpm doesn't randomly change the babel-plugin-react-compiler version #73703

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Ensure pnpm doesn't randomly change the babel-plugin-react-compiler version #73703

merged 1 commit into from
Dec 10, 2024
+7 −6

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 9, 2024 •
edited
Loading

Missing peer dependency in dev dependencies in the next package can result in unrelated updates.
This happened to me when installing @babel/plugin-proposal-explicit-resource-management

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Dec 9, 2024
@eps1lon Graphite App
Copy link
Member Author

eps1lon commented Dec 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ijjk
Copy link
Member

ijjk commented Dec 9, 2024 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 9, 2024 •
edited
Loading

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
buildDuration 19.7s 17.9s N/A
buildDurationCached 17s 14.7s N/A
nodeModulesSize 409 MB 409 MB ⚠️ +170 B
nextStartRea..uration (ms) 460ms 460ms ✓
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
index.html gzip 524 B 524 B ✓
link.html gzip 538 B 539 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 524 B 524 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
middleware-b..fest.js gzip 671 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
523-experime...dev.js gzip 322 B 322 B ✓
523.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 127 kB 127 kB ✓
app-page-tur..prod.js gzip 140 kB 140 kB ✓
app-page-tur..prod.js gzip 135 kB 135 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 122 kB 122 kB ✓
app-route-ex...dev.js gzip 37.1 kB 37.1 kB ✓
app-route-ex..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 25.1 kB 25.1 kB ✓
app-route-tu..prod.js gzip 24.9 kB 24.9 kB ✓
app-route.ru...dev.js gzip 38.7 kB 38.7 kB ✓
app-route.ru..prod.js gzip 24.9 kB 24.9 kB ✓
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB ✓
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB ✓
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB ✓
pages-turbo...prod.js gzip 21.3 kB 21.3 kB ✓
pages.runtim...dev.js gzip 27 kB 27 kB ✓
pages.runtim..prod.js gzip 21.3 kB 21.3 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.35 MB 2.35 MB ✓
build cache
vercel/next.js canary vercel/next.js sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax Change
0.pack gzip 2.04 MB 2.04 MB N/A
index.pack gzip 146 kB 145 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 3e3cf98

@eps1lon eps1lon force-pushed the sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax branch from 6050169 to 0ecd390 Compare December 9, 2024 17:16
@ijjk ijjk added the type: next label Dec 9, 2024
@eps1lon eps1lon force-pushed the sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax branch from 0ecd390 to 47847f3 Compare December 9, 2024 19:06
@eps1lon eps1lon mentioned this pull request Dec 9, 2024
Merged
@eps1lon eps1lon changed the title Ensure inline snapshots can be updated in tests with using syntax Ensure pnpm doesn't randomly change the babel-plugin-react-compiler version Dec 9, 2024
@eps1lon eps1lon force-pushed the sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax branch from 47847f3 to d5a4018 Compare December 9, 2024 21:44
@eps1lon eps1lon marked this pull request as ready for review December 9, 2024 21:44
@eps1lon eps1lon mentioned this pull request Dec 9, 2024
Draft
@eps1lon
Ensure pnpm doesn't randomly change the babel-plugin-react-compiler…
3e3cf98 
… version

Missing peer dependency in dev dependencies in the `next` package
can result in unrelated updates.
This happened to me when installing `@babel/plugin-proposal-explicit-resource-management`
@eps1lon eps1lon force-pushed the sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax branch from d5a4018 to 3e3cf98 Compare December 9, 2024 23:29
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/babel-plugin-react-compiler@19.0.0-beta-df7b47d-20241124 None 0 5.08 MB react-bot

🚮 Removed packages: npm/babel-plugin-react-compiler@19.0.0-beta-37ed2a7-20241206

View full report↗︎

@eps1lon eps1lon merged commit cea253e into canary Dec 10, 2024
107 of 112 checks passed
@eps1lon eps1lon deleted the sebbie/12-09-ensure_inline_snapshots_can_be_updated_in_tests_with_using_syntax branch December 10, 2024 01:11
@eps1lon eps1lon mentioned this pull request Dec 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubieowoce lubieowoce lubieowoce approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eps1lon @ijjk @lubieowoce