Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open tab when running next dev #8

Merged
merged 5 commits into from
Oct 17, 2016
+12 −1
Merged

Open tab when running next dev #8

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18b12a1
Open tab when running next dev
impronunciable Oct 15, 2016
868f48a
Added NEXT_OPEN_BROWSER env var to prevent open a browser tab on next…
impronunciable Oct 16, 2016
eaeae99
Fixed conflicts with master
impronunciable Oct 17, 2016
d752776
using regexp for testing false on env var
impronunciable Oct 17, 2016
ed6f900
adding ! to if
impronunciable Oct 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion bin/next-dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#!/usr/bin/env node
import { exec } from 'child_process'
import { resolve, join } from 'path'
import parseArgs from 'minimist'
import Server from '../server'
Expand All @@ -16,6 +17,12 @@ const argv = parseArgs(process.argv.slice(2), {
}
})

const open = url => {
const openers = { darwin: 'open', win32: 'start' }
const cmdName = openers[process.platform] || 'xdg-open'
exec(`${cmdName} ${url}`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably a node module for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said this looks short and sweet :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one that does this and some checking, but for our use case we don't need the extra stuff https://github.com/domenic/opener/blob/master/opener.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pretty small module though. Ok with me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sindresorhus/opn

}

const dir = resolve(argv._[0] || '.')

build(dir)
Expand All @@ -25,13 +32,17 @@ build(dir)
console.log('> Ready on http://localhost:%d', argv.port)

// Check if pages dir exists and warn if not
if (!await exists(join(dir, 'pages'))) {
if (!(await exists(join(dir, 'pages')))) {
if (await exists(join(dir, '..', 'pages'))) {
console.warn('> No `pages` directory found. Did you mean to run `next` in the parent (`../`) directory?')
} else {
console.warn('> Couldn\'t find a `pages` directory. Please create one under the project root')
}
}

if (!/^(false|0)$/i.test(process.env.NEXT_OPEN_BROWSER)) {
open(`http://localhost:${argv.port}`)
}
})
.catch((err) => {
console.error(err)
Expand Down