Expose hook into the module resolution (resolve)
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Aug 26, 2020
|
@styfle tests passing now 😉 |
guybedford
approved these changes
Aug 31, 2020
styfle
reviewed
Aug 31, 2020
|
Implemented the suggestions and got the tests passing again 😉 |
styfle
reviewed
Sep 8, 2020
styfle
reviewed
Sep 8, 2020
styfle
reviewed
Sep 8, 2020
ramosbugs
added a commit
to ramosbugs/serverless-next.js
that referenced
this pull request
Nov 7, 2020
This PR makes two changes to the `lambda-at-edge` builder to better support Yarn v2 projects when using the `serverless-trace` target. 1. Adds a `baseDir` build option to specify the base directory to search for `node_modules`. Currently, the builder sets this to `process.cwd()`, but Yarn v2 often hoists dependencies across multiple workspaces so that they can be shared. Without this change, all dependencies from ancestor directories are omitted, leading to import errors at runtime. 2. Adds a `resolve` build option which allows projects to specify their own custom resolvers, such as when supporting Yarn v2's PnP mode. This leverages the resolver hook added in vercel/nft#153, which also required upgrading from `@zeit/node-file-trace` to the latest version of `@vercel/nft`. Note that even after this change, Yarn v2's PnP mode is still incompatible with the builder since the builder ends up collapsing all of the PnP dependencies into a single `node_modules` directory. This causes multiple versions of a package to clobber one another.
ramosbugs
added a commit
to ramosbugs/serverless-next.js
that referenced
this pull request
Nov 7, 2020
This PR makes two changes to the `lambda-at-edge` builder to better support Yarn v2 projects when using the `serverless-trace` target. 1. Adds a `baseDir` build option to specify the base directory to search for `node_modules`. Currently, the builder sets this to `process.cwd()`, but Yarn v2 often hoists dependencies across multiple workspaces so that they can be shared. Without this change, all dependencies from ancestor directories are omitted, leading to import errors at runtime. 2. Adds a `resolve` build option which allows projects to specify their own custom resolvers, such as when supporting Yarn v2's PnP mode. This leverages the resolver hook added in vercel/nft#153, which also required upgrading from `@zeit/node-file-trace` to the latest version of `@vercel/nft`. Note that even after this change, Yarn v2's PnP mode is still incompatible with the builder since the builder ends up collapsing all of the PnP dependencies into a single `node_modules` directory. This causes multiple versions of a package to clobber one another.
danielcondemarin
added a commit
to serverless-nextjs/serverless-next.js
that referenced
this pull request
Nov 11, 2020
…less-trace (#779) * Add baseDir and resolve build options to serverless-trace This PR makes two changes to the `lambda-at-edge` builder to better support Yarn v2 projects when using the `serverless-trace` target. 1. Adds a `baseDir` build option to specify the base directory to search for `node_modules`. Currently, the builder sets this to `process.cwd()`, but Yarn v2 often hoists dependencies across multiple workspaces so that they can be shared. Without this change, all dependencies from ancestor directories are omitted, leading to import errors at runtime. 2. Adds a `resolve` build option which allows projects to specify their own custom resolvers, such as when supporting Yarn v2's PnP mode. This leverages the resolver hook added in vercel/nft#153, which also required upgrading from `@zeit/node-file-trace` to the latest version of `@vercel/nft`. Note that even after this change, Yarn v2's PnP mode is still incompatible with the builder since the builder ends up collapsing all of the PnP dependencies into a single `node_modules` directory. This causes multiple versions of a package to clobber one another. Co-authored-by: Daniel <danielconde9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.