Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix redis connection #355

Merged
merged 6 commits into from
Jul 14, 2023
Merged

chore(ci): fix redis connection #355

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9352aa
chore(ci): fix redis connection
styfle Jul 14, 2023
ed05004
Only run on ubuntu and fix connection string
styfle Jul 14, 2023
111f47d
Fix conditional
styfle Jul 14, 2023
3939f45
Remove unused `if`
styfle Jul 14, 2023
1c725cc
Add a comment
styfle Jul 14, 2023
4569cf1
Conditional env var
styfle Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ jobs:
os: [ubuntu-latest, macos-latest, windows-latest]
node: [14, 16, 18]
runs-on: ${{ matrix.os }}
services:
redis:
# See workaround https://github.com/actions/runner/issues/822#issuecomment-1524826092
image: ${{ (matrix.os == 'ubuntu-latest') && 'redis:6.0.20' || '' }}
ports:
- 6379:6379
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node }}
Expand All @@ -36,7 +42,7 @@ jobs:
run: yarn build
- name: Run Tests
env:
BULL_REDIS_CONNECTION: ${{ secrets.BULL_REDIS_CONNECTION }}
BULL_REDIS_CONNECTION: ${{ (matrix.os == 'ubuntu-latest') && 'redis://127.0.0.1:6379/0' || '' }}
run: yarn test-verbose
- name: Maybe Release
if: matrix.os == 'ubuntu-latest' && matrix.node == 18 && github.event_name == 'push' && github.ref == 'refs/heads/main'
Expand Down