Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): update ecmascript tests #448

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

styfle
Copy link
Member

@styfle styfle commented Oct 29, 2024

This PR updates the ecmascript tests using the instructions here:

https://github.com/vercel/nft/blob/main/test/ecmascript/README.md

We are currently failing a couple new test categories, RegExp Pattern Modifiers (stage 4) and Duplicate named capturing groups (stage 3), so those are skipped for now.

In a future PR, we can try updating acorn to see if fixes those tests.

@styfle styfle marked this pull request as ready for review October 29, 2024 17:30
@styfle styfle requested review from ijjk and a team as code owners October 29, 2024 17:30
@styfle styfle requested a review from TooTallNate October 29, 2024 17:30
@styfle styfle enabled auto-merge (squash) October 29, 2024 17:37
@styfle styfle merged commit e7f8984 into main Oct 29, 2024
17 checks passed
@styfle styfle deleted the styfle/bump-ecmascript-tests branch October 29, 2024 18:10
Copy link

github-actions bot commented Nov 5, 2024

🎉 This PR is included in version 0.27.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants