This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
dockerfile.linux: use Node.js 16.x to avoid glibc issues #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've kicked off a |
|
cc @jesec |
|
@leerob and @robertsLando I've been basing any asset building I do on this commit, which resolves the environment setup issues on the linux builds. I regard this as a must-merge if we're to make a release anytime soon. |
|
an example of a full suite of builds that uses the latest patches and this commit can be found here: https://github.com/baparham/pkg-fetch/actions/runs/4065087301 |
robertsLando
approved these changes
Feb 1, 2023
|
https://github.com/baparham/pkg-fetch/actions/runs/4065087301 passed all (except arm) archs with this commit and the fix from #273 |
|
@leerob 👍🏼 |
robertsLando
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #264 and fixes binary build failures that try to do
yum install nodejs @ 18.12.1since the glibc requirements of that nodejs package are >= 2.28, and it appears the nodejs we need in the environment of the Docker container is used for bootstrappingpkg-fetchto do the actual buildThis should work as a workaround for now until a decision is made regarding whether to build on a newer runner for future node.js versions.