Skip to content
This repository has been archived by the owner on Jan 13, 2024. It is now read-only.

feat: support node v19 #1862

Merged
merged 1 commit into from
Mar 18, 2023
Merged

feat: support node v19 #1862

merged 1 commit into from
Mar 18, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 6, 2023

In combination with vercel/pkg-fetch#274, this adds support for node 19.6

@robertsLando
Copy link
Contributor

cc @baparham

@phated
Copy link
Contributor Author

phated commented Feb 17, 2023

@robertsLando I think pkg-fetch needs a release before I can update this. Is that correct? I'd love to get this released, since node 20 is less than 2 months away and we should be tracking the changes necessary through the unstable version

@robertsLando
Copy link
Contributor

We are working to try setting up back ARM GitHub runners, ATM a new release would miss all ARM e executables otherwise

Copy link
Contributor

@baparham baparham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally on node 18 and node 19 and it seems to do what is required to support node 19. Thanks for fixing @phated

@baparham
Copy link
Contributor

Perhaps this needs a rebase also @phated and then I think we can merge it in once it's updated

@phated
Copy link
Contributor Author

phated commented Mar 18, 2023

Rebased with the github UI

@baparham baparham changed the title feat: Support node v19 feat: support node v19 Mar 18, 2023
@baparham baparham merged commit e388983 into vercel:main Mar 18, 2023
@phated phated deleted the phated/node19 branch March 19, 2023 04:02
pcnate pushed a commit to pcnate/pkg that referenced this pull request Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants